Bug 64075 – Move remaining enums out of SVG*Element classes

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Nikolas Zimmermann]

Move remaining enums out of SVG*Element classes. This is a preparation patch for bug 63797.
Also move the SVGPropertyTraits template specializations for enum types before the class definition in the header, otherwhise we can't use SVGPropertyTraits<FooType>::fromString/toString in the DECLARE_ANIMATED* macros, which is needed soon.

[Nikolas Zimmermann]

Created attachment 99960 [details]
Patch

Splitted up from bug 63797.

[Dirk Schulze]

Comment on attachment 99960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99960&action=review

r=me. Not sure if you should remove the comment about forward declaration or add it to all elements. Up to you:

> Source/WebCore/svg/SVGTextContentElement.h:75
> +    // Forward declare these enums in the w3c naming scheme, for IDL generation

I wounder why you did not add this comment on the other enums like for SVGMarker or SVGGradient?!?

[Nikolas Zimmermann]

(In reply to comment #2)
> (From update of attachment 99960 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=99960&action=review
> 
> r=me. Not sure if you should remove the comment about forward declaration or add it to all elements. Up to you:
> 
> > Source/WebCore/svg/SVGTextContentElement.h:75
> > +    // Forward declare these enums in the w3c naming scheme, for IDL generation
> 
> I wounder why you did not add this comment on the other enums like for SVGMarker or SVGGradient?!?
Just forgot it. Fixed.

Landed in r90560.