Bug 64075 - Move remaining enums out of SVG*Element classes
Summary: Move remaining enums out of SVG*Element classes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-07 01:56 PDT by Nikolas Zimmermann
Modified: 2011-07-07 07:51 PDT (History)
1 user (show)

See Also:


Attachments
Patch (57.64 KB, patch)
2011-07-07 02:20 PDT, Nikolas Zimmermann
krit: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2011-07-07 01:56:46 PDT
Move remaining enums out of SVG*Element classes. This is a preparation patch for bug 63797.
Also move the SVGPropertyTraits template specializations for enum types before the class definition in the header, otherwhise we can't use SVGPropertyTraits<FooType>::fromString/toString in the DECLARE_ANIMATED* macros, which is needed soon.
Comment 1 Nikolas Zimmermann 2011-07-07 02:20:39 PDT
Created attachment 99960 [details]
Patch

Splitted up from bug 63797.
Comment 2 Dirk Schulze 2011-07-07 04:39:57 PDT
Comment on attachment 99960 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99960&action=review

r=me. Not sure if you should remove the comment about forward declaration or add it to all elements. Up to you:

> Source/WebCore/svg/SVGTextContentElement.h:75
> +    // Forward declare these enums in the w3c naming scheme, for IDL generation

I wounder why you did not add this comment on the other enums like for SVGMarker or SVGGradient?!?
Comment 3 Nikolas Zimmermann 2011-07-07 07:18:28 PDT
(In reply to comment #2)
> (From update of attachment 99960 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=99960&action=review
> 
> r=me. Not sure if you should remove the comment about forward declaration or add it to all elements. Up to you:
> 
> > Source/WebCore/svg/SVGTextContentElement.h:75
> > +    // Forward declare these enums in the w3c naming scheme, for IDL generation
> 
> I wounder why you did not add this comment on the other enums like for SVGMarker or SVGGradient?!?
Just forgot it. Fixed.

Landed in r90560.