Bug 64044 – Don't call into Image::loadPlatformResource() for Chromium Autofill popup items without icons

• Status: RESOLVED
• Resolution: WONTFIX
• Component: New Bugs

[Ilya Sherman]

Don't call into Image::loadPlatformResource() for Chromium Autofill popup items without icons

[Ilya Sherman]

Created attachment 99901 [details]
Patch

[Adam Barth]

Comment on attachment 99901 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99901&action=review

R- for lack of tests.

> Source/WebCore/ChangeLog:8
> +        No new tests because the changes are all in platform-specific Chromium Autofill code.

That's not a reason not to have tests!

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1043
> +      image = Image::loadPlatformResource(itemIcon.utf8().data());

Bad indent

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1192
> -    RefPtr<Image> image(Image::loadPlatformResource(icon.utf8().data()));
> +    RefPtr<Image> image;
> +    if (!icon.isEmpty())
> +      image = Image::loadPlatformResource(icon.utf8().data());

I don't really understand this pattern.  Why doesn't loadPlatformResource just return a null ptr if icon is empty?

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1382
> +          iconImage = Image::loadPlatformResource(icon.utf8().data());

Bad indent.

[Ilya Sherman]

(In reply to comment #2)
> > Source/WebCore/platform/chromium/PopupMenuChromium.cpp:1192
> > -    RefPtr<Image> image(Image::loadPlatformResource(icon.utf8().data()));
> > +    RefPtr<Image> image;
> > +    if (!icon.isEmpty())
> > +      image = Image::loadPlatformResource(icon.utf8().data());
> 
> I don't really understand this pattern.  Why doesn't loadPlatformResource just return a null ptr if icon is empty?

Fair enough, I'll make that change instead.