Bug 64031 - Split Driver, DriverOutput and DriverInput out into a new driver.py file
Summary: Split Driver, DriverOutput and DriverInput out into a new driver.py file
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
Depends on:
Reported: 2011-07-06 14:13 PDT by Eric Seidel (no email)
Modified: 2011-07-06 15:35 PDT (History)
3 users (show)

See Also:

Patch (50.13 KB, patch)
2011-07-06 14:17 PDT, Eric Seidel (no email)
abarth: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-07-06 14:13:28 PDT
Split Driver, DriverOutput and DriverInput out into a new driver.py file
Comment 1 Eric Seidel (no email) 2011-07-06 14:17:58 PDT
Created attachment 99878 [details]
Comment 2 Adam Barth 2011-07-06 14:22:34 PDT
Comment on attachment 99878 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=99878&action=review

> Tools/Scripts/webkitpy/layout_tests/port/__init__.py:37
> -from test import unit_test_filesystem
> +import builders  # Why is this in port?
> -import builders
> +from base import Port  # It's possible we don't need to export this virtual baseclass outside the module.
> +from driver import Driver, DriverInput, DriverOutput

We've had pain importing things in __init__ files before.  Maybe this will be ok though...
Comment 3 WebKit Review Bot 2011-07-06 14:27:40 PDT
Comment on attachment 99878 [details]

Rejecting attachment 99878 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
patching file Tools/Scripts/webkitpy/layout_tests/port/webkit.py
patching file Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
patching file Tools/Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py
patching file Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8986884
Comment 4 Eric Seidel (no email) 2011-07-06 15:35:09 PDT
Committed r90506: <http://trac.webkit.org/changeset/90506>