Bug 64031 – Split Driver, DriverOutput and DriverInput out into a new driver.py file

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Eric Seidel (no email)]

Split Driver, DriverOutput and DriverInput out into a new driver.py file

[Eric Seidel (no email)]

Created attachment 99878 [details]
Patch

[Adam Barth]

Comment on attachment 99878 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99878&action=review

> Tools/Scripts/webkitpy/layout_tests/port/__init__.py:37
> -from test import unit_test_filesystem
> +import builders  # Why is this in port?
>  
> -import builders
> +from base import Port  # It's possible we don't need to export this virtual baseclass outside the module.
> +from driver import Driver, DriverInput, DriverOutput

We've had pain importing things in __init__ files before.  Maybe this will be ok though...

[WebKit Review Bot]

Comment on attachment 99878 [details]
Patch

Rejecting attachment 99878 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
ls/Scripts/webkitpy/layout_tests/port/test.py
patching file Tools/Scripts/webkitpy/layout_tests/port/webkit.py
patching file Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
patching file Tools/Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py
patching file Tools/Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8986884

[Eric Seidel (no email)]

Committed r90506: <http://trac.webkit.org/changeset/90506>