Bug 64030 – REGRESSION: Incorrect layout at recline-online.com

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

Safari: ok
Firefox: ok
IE: ok
Opera: ok
Mozilla: ok
Google Chromium 14.0.812.0 (91475): Fail

Message back from Google Chrome:
Thanks for the report. Confirmed with Chromium 14.0.812.0 (91475) on Mac OS 10.6.8. But this seems to be Webkit issue, because I can reproduce this with the latest Webkit (90391), too.

screen shot a is the desired layout.

Created attachment 99877 [details]
this is the desired layout

[Mehmet]

Broken page: http://recline-online.com

Chromium Bug: http://code.google.com/p/chromium/issues/detail?id=88570

[Alexey Proskuryakov]

<rdar://problem/9734076>

[Simon Fraser (smfr)]

Why did you attach a screenshot as an MS Word document? PNG please.

[Simon Fraser (smfr)]

Created attachment 99905 [details]
Screenshot of MSWord document

[Simon Fraser (smfr)]

This is caused by <div align="right">.

[Dominic Cooney]

Created attachment 99915 [details]
Reduction

[Dominic Cooney]

The layout in Safari 5.0.4 and Firefox 5.0 is the same and matches the "desired" layout (assuming my .doc viewer works :/)

The layout in WebKit nightly r90503 and Chrome 14.0.803.0 (WebKit r89703) is the same and differs from the "desired" layout.

The "problem" element in the layout is the interaction between the first <div align="right"> and the <table align="left"> child. The reduction in attachment 99915 [details] makes this clearer. The align="left" causes the table to float out of the div. In Safari 5.0.4 and Firefox 5.0, the table appears on the left. In WebKit nightly r90503 the table appears on the right.

[Simon Fraser (smfr)]

Would be good to know when this regressed.

[Mehmet]

(In reply to comment #9)
> Would be good to know when this regressed.

Simon, I checked the older builds.

The regression range is between r68242 and r68419.

Regards
Mehmet

[Robert Hogan]

git bisect says it's : http://trac.webkit.org/changeset/68362

[Robert Hogan]

Created attachment 100574 [details]
Patch

Hello,

I am a bit confused as to what is being communicated - sorry.

I have had a look at my layout code and corrected so the content now sits correctly left to right. But for some reason the page looks tiny when compared to how it looks on all other browsers.

Can you please advise if this is a bug or again another detail in the code that needs addressing?

Many thanks.

[Robert Hogan]

(In reply to comment #13)
> Hello,
> 
> I am a bit confused as to what is being communicated - sorry.
> 
> I have had a look at my layout code and corrected so the content now sits correctly left to right. But for some reason the page looks tiny when compared to how it looks on all other browsers.
> 
> Can you please advise if this is a bug or again another detail in the code that needs addressing?
> 
> Many thanks.

Can you attach the offending page to this bug?

Created attachment 100661 [details]
page looks tiny in google chrome

Created attachment 100662 [details]
example of how it should look

[Simon Fraser (smfr)]

Screenshots in MS Word make me sad. Why not just attach image files?

[Robert Hogan]

The size is normal for me in both unpatched Chromium and patch QtTestBrowser. By normal, I mean the same as Firefox 4 and Opera. I am testing http://recline-online.com/. If the code you see the problem with is not live, you should attach it to a new bug I think. If there is an issue it sounds like a separate one.

[Dominic Cooney]

Also works for me in Chrome 14.0.814.0 (Official Build 91661) dev Mac WebKit 535.1 (trunk@90501).

Nathalie: Check in Chrome that Wrench → Zoom is 100% and not something smaller.

[Robert Hogan]

Created attachment 100830 [details]
Patch

The page looks great in google chrome now.
Many thanks all.

[Dave Hyatt]

Comment on attachment 100830 [details]
Patch

Yeah, this looks correct to me. I just lost a bit of code.

[WebKit Review Bot]

Comment on attachment 100830 [details]
Patch

Clearing flags on attachment: 100830

Committed r91277: <http://trac.webkit.org/changeset/91277>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.