RESOLVED FIXED 64027
garden-o-matic should use a favicon to indicate current state. 
https://bugs.webkit.org/show_bug.cgi?id=64027
Summary garden-o-matic should use a favicon to indicate current state.
Dimitri Glazkov (Google)
Reported 2011-07-06 13:42:29 PDT
garden-o-matic should use a favicon to indicate current state.
Attachments
Patch (6.06 KB, patch)
2011-07-06 13:44 PDT, Dimitri Glazkov (Google) 		abarth: review+
abarth: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-07-06 13:44:01 PDT
Created attachment 99873 [details] Patch
Adam Barth
Comment 2 2011-07-06 13:49:39 PDT
Comment on attachment 99873 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99873&action=review > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:48 > +<link rel=icon id=favicon type=image/png href=favicon-green.png> pls use " around attribute values. > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:18 > + document.getElementById('favicon').href = 'favicon-' + (hasFailures ? 'red' : 'green') + '.png'; I was thinking we'd use jQuery to interact with the DOM: var faviconURL = 'favicon-' + (hasFailures ? 'red' : 'green') + '.png'; $('#favicon').attr('href', faviconURL); I'm not sure it really matters, but just to be consistent.
Dimitri Glazkov (Google)
Comment 3 2011-07-06 14:10:57 PDT
Committed r90496: <http://trac.webkit.org/changeset/90496>
Note You need to log in before you can comment on or make changes to this bug.