Bug 64023 - DFG JIT op_call implementation will flush registers even when those registers are dead
Summary: DFG JIT op_call implementation will flush registers even when those registers...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-07-06 13:10 PDT by Filip Pizlo
Modified: 2011-07-06 14:40 PDT (History)
1 user (show)

See Also:

the patch (8.89 KB, patch)
2011-07-06 13:29 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-07-06 13:10:42 PDT
The DFG JIT op_call implementation invokes flushRegisters() to ensure that any live registers are spilled and later refilled on-demand, since in our calling convention all registers are caller-save.  However, in the current implementation flushRegisters() may also flush registers that are killed by the call.
Comment 1 Filip Pizlo 2011-07-06 13:29:26 PDT
Created attachment 99870 [details]
the patch
Comment 2 WebKit Review Bot 2011-07-06 14:40:25 PDT
Comment on attachment 99870 [details]
the patch

Clearing flags on attachment: 99870

Committed r90502: <http://trac.webkit.org/changeset/90502>
Comment 3 WebKit Review Bot 2011-07-06 14:40:29 PDT
All reviewed patches have been landed.  Closing bug.