Bug 64022 - DFG speculative JIT contains a FIXME for rewinding speculative code generation that has already been fixed
Summary: DFG speculative JIT contains a FIXME for rewinding speculative code generatio...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-06 13:07 PDT by Filip Pizlo
Modified: 2011-07-14 12:31 PDT (History)
1 user (show)

See Also:

Attachments
the patch (1.38 KB, patch)
2011-07-06 13:49 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-07-06 13:07:53 PDT 
The DFG speculative JIT may perform a speculation that turns out to be statically false.  In this case, speculative code generation is rolled back.  Despite the fact that this feature is already implemented, there is still a FIXME in DFGSpeculativeJIT.h that indicates that we should implement this already-implemented feature.  Additionally, the same code path also generates a speculation check despite the fact that any code generated by this path will be rewound.
Comment 1 Filip Pizlo 2011-07-06 13:49:34 PDT 
Created attachment 99875 [details]
the patch
Comment 2 WebKit Review Bot 2011-07-14 12:31:36 PDT 
Comment on attachment 99875 [details]
the patch

Clearing flags on attachment: 99875

Committed r91022: <http://trac.webkit.org/changeset/91022>
Comment 3 WebKit Review Bot 2011-07-14 12:31:40 PDT 
All reviewed patches have been landed.  Closing bug.