Bug 64009 - [chromium] Add compositor texture manager soft limits and lost focus reclaiming
Summary: [chromium] Add compositor texture manager soft limits and lost focus reclaiming
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrienne Walker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-06 11:28 PDT by Adrienne Walker
Modified: 2011-07-06 15:33 PDT (History)
4 users (show)

See Also:


Attachments
Patch (12.57 KB, patch)
2011-07-06 11:33 PDT, Adrienne Walker
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2011-07-06 11:28:35 PDT
[chromium] Add compositor texture manager soft limits and lost focus reclaiming
Comment 1 Adrienne Walker 2011-07-06 11:33:24 PDT
Created attachment 99855 [details]
Patch
Comment 2 James Robinson 2011-07-06 13:27:07 PDT
Comment on attachment 99855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99855&action=review

Looks good.

> Source/WebCore/platform/graphics/chromium/TextureManager.h:66
> +    bool reduceMemoryToLimit(size_t);

the return value is never used, can you change it to be void?
Comment 3 Adrienne Walker 2011-07-06 13:34:34 PDT
(In reply to comment #2)
> (From update of attachment 99855 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=99855&action=review
>
> > Source/WebCore/platform/graphics/chromium/TextureManager.h:66
> > +    bool reduceMemoryToLimit(size_t);
> 
> the return value is never used, can you change it to be void?

Good catch.  Can do.
Comment 4 Adrienne Walker 2011-07-06 15:33:36 PDT
Committed r90505: <http://trac.webkit.org/changeset/90505>