Bug 64001 - REGRESSION(r90212-r90246?): http/tests/cookies/third-party-cookie-relaxing.html fails on Snow Leopard
Summary: REGRESSION(r90212-r90246?): http/tests/cookies/third-party-cookie-relaxing.ht...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: InRadar
Depends on:
Blocks: 65781
  Show dependency treegraph
Reported: 2011-07-06 09:33 PDT by Eric Seidel (no email)
Modified: 2020-06-25 17:57 PDT (History)
6 users (show)

See Also:


Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-07-06 09:33:43 PDT
http/tests/cookies/third-party-cookie-relaxing.html is failing under new-run-webkit-tests on the snow leopard bot
Comment 1 Eric Seidel (no email) 2011-07-06 09:35:30 PDT
Example failure:

--- /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/cookies/third-party-cookie-relaxing-expected.txt 
+++ /Volumes/Data/WebKit-BuildSlave/snowleopard-intel-release-tests/build/layout-test-results/http/tests/cookies/third-party-cookie-relaxing-actual.txt 
@@ -26,7 +26,7 @@
 ALERT: Test stage 5 document.cookie is: 
 ALERT: http://localhost:8000/cookies/resources/cookie-utility.php?queryfunction=setFooCookie
 ALERT: XHR response - Set the foo cookie
-ALERT: Test stage 6 document.cookie is: foo=awesomevalue
+ALERT: Test stage 6 document.cookie is: 
 ALERT: Restricting to first party only cookies
 ALERT: http://localhost:8000/cookies/resources/cookie-utility.php?queryfunction=deleteCookies
 ALERT: XHR response - Deleted all cookies
@@ -39,9 +39,9 @@
 ALERT: Test stage 8 document.cookie is: 
 ALERT: http://localhost:8000/cookies/resources/cookie-utility.php?queryfunction=setFooCookie
 ALERT: XHR response - Set the foo cookie
-ALERT: Test stage 9 document.cookie is: foo=awesomevalue
+ALERT: Test stage 9 document.cookie is: 
 ALERT: Restricting to first party only cookies
 ALERT: http://localhost:8000/cookies/resources/cookie-utility.php?queryfunction=setFooAndBarCookie
 ALERT: XHR response - Set the foo and bar cookies
-ALERT: Test stage 10 document.cookie is: bar=anotherawesomevalue; foo=awesomevalue
+ALERT: Test stage 10 document.cookie is:
Comment 2 Eric Seidel (no email) 2011-07-06 09:37:19 PDT
new-run-webkit-tests http/tests/cookies/third-party-cookie-relaxing.html

fails when run straight on my machine.  Then again, so does:

old-run-webkit-tests http/tests/cookies/third-party-cookie-relaxing.html
Comment 3 Eric Seidel (no email) 2011-07-06 09:39:59 PDT
It also fails for me with:
old-run-webkit-tests http/tests/cookies
old-run-webkit-tests http

I'm trying to understand how the test is supposed to work?


Maybe there was a recent regression in behavior on Snow Leopard which happen to correspond with the NRWT transition?

Maybe NRWT running cookie-tests in parallel manages to permanently "jam" the CF cookie store?  Donno.
Comment 4 Eric Seidel (no email) 2011-07-06 09:42:44 PDT
Qt just added support for third-party cookies, and their results seem to match SL, in at least the 6 and 9 cases:
Comment 5 Eric Seidel (no email) 2011-07-06 09:45:34 PDT
Bug 63545 is another cookie-related failure which occurs on my machine.  This one of course occurs on the SL bot as well:
Comment 6 Eric Seidel (no email) 2011-07-06 10:14:20 PDT
Even if I move my ~/Library/Cookies/Cookies.plist file out of the way, the test still fails for me.
Comment 7 Eric Seidel (no email) 2011-07-06 10:14:43 PDT
Turns out this has nothing to do with NRWT, now that I look at the bot history (with webkit-patch failure-reason).
Comment 8 Eric Seidel (no email) 2011-07-06 10:19:51 PDT
I don't see any changes in that range which seem particularly related.  Perhaps failure-reason is confused.
Comment 9 Eric Seidel (no email) 2011-07-06 10:34:08 PDT
The only possibly-related changes in that range are to the JIT.  But I don't see how they could affect this test:

I checked the results.  Unless build.webkit.org/results is lying, it's definitely this range.  I've not tried using git-bisect, but I think the build was broken a bunch in there, so it may not answer our question.
Comment 10 Adam Roben (:aroben) 2011-07-06 12:46:51 PDT
TestFailures says this test is flaky:

r90315 (31042) (results.html): fail
r90310 (31041) (results.html): pass
r90308 (31040) (results.html): pass
r90288 (31027) (results.html): fail
r90285 (31026) (results.html): pass
r90284 (31025) (results.html): fail
r90280 (31024) (results.html): pass
r90279 (31023) (results.html): fail
r90273 (31022) (results.html): pass
r90271 (31019) (results.html): fail

It always fails with the same diff: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r90315%20(31042)/http/tests/cookies/third-party-cookie-relaxing-pretty-diff.html
Comment 11 Alexey Proskuryakov 2020-06-25 17:56:23 PDT
This is no longer happening. Karl removed the expectation via bug 213620.
Comment 12 Radar WebKit Bug Importer 2020-06-25 17:57:17 PDT