Bug 63999 – Web Inspector: Add support for clearing cache and cookies from network panel.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Vsevolod Vlasov]

Add support for clearing cache and cookies from network panel.

[Vsevolod Vlasov]

Created attachment 99848 [details]
Patch

[WebKit Review Bot]

Comment on attachment 99848 [details]
Patch

Attachment 99848 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/8995070

[Pavel Feldman]

Comment on attachment 99848 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99848&action=review

r+ with nits.

> LayoutTests/http/tests/inspector/network/network-clear-cookies.html-disabled:14
> +    internals.setInspectorResourcesDataSizeLimits(document, 10 * 1000 * 1000, 1000 * 1000);

This should be a part of the network-test.js

> Source/WebCore/inspector/InspectorClient.h:55
> +    virtual void clearBrowserCache() { };

nuke ;

> Source/WebCore/inspector/InspectorResourceAgent.cpp:478
> +void InspectorResourceAgent::clearBrowserCache(ErrorString* errorString)

Mac build failed with unused errorString

> Source/WebCore/inspector/InspectorResourceAgent.cpp:483
> +void InspectorResourceAgent::clearBrowserCookies(ErrorString* errorString)

ditto

> Source/WebKit/chromium/public/WebDevToolsAgentClient.h:62
> +    virtual void clearBrowserCache() { };

nuke ;

[Vsevolod Vlasov]

Committed r90553: <http://trac.webkit.org/changeset/90553>

[Vsevolod Vlasov]

Fixed nits except for this one.

> > LayoutTests/http/tests/inspector/network/network-clear-cookies.html-disabled:14
> > +    internals.setInspectorResourcesDataSizeLimits(document, 10 * 1000 * 1000, 1000 * 1000);
> 
> This should be a part of the network-test.js
I'll deal with it here https://bugs.webkit.org/show_bug.cgi?id=64078