Bug 63995 - [Qt] [WK2] Add touch mocking to Qt's Minibrowser
Summary: [Qt] [WK2] Add touch mocking to Qt's Minibrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-07-06 08:26 PDT by Benjamin Poulain
Modified: 2011-07-06 12:35 PDT (History)
0 users

See Also:


Attachments
Patch (4.98 KB, patch)
2011-07-06 08:58 PDT, Benjamin Poulain
kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2011-07-06 08:26:49 PDT
Minibrowser is unusable with the touch view on desktop because the platform does not send any touch event.
We should create fake touch events for mouse events.
Comment 1 Benjamin Poulain 2011-07-06 08:58:06 PDT
Created attachment 99839 [details]
Patch
Comment 2 Andreas Kling 2011-07-06 09:33:00 PDT
Comment on attachment 99839 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99839&action=review

r=me with some kennethisms

> Tools/ChangeLog:3
> +        [Qt] [WK2] Add touch mocking to Qt's Minibrowser

MiniBrowser!!!111twotwotwo

> Tools/ChangeLog:8
> +        The mouse event are intercepted through QCoreApplication::notify(),

event -> events

> Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:83
> +    /* We try to be smart, if we received real touch event, we are probably on a device
> +       with touch screen, and we should not have touch mocking */

// comments, please!
Comment 3 Benjamin Poulain 2011-07-06 12:35:43 PDT
I just noticed I forgot to close this bug at work...

This has landed: http://trac.webkit.org/changeset/90475