Bug 63990 - Web Inspector: implement drag'n'drop in the elements panel for reordering nodes.
Summary: Web Inspector: implement drag'n'drop in the elements panel for reordering nodes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-06 06:27 PDT by Pavel Feldman
Modified: 2011-07-06 08:25 PDT (History)
10 users (show)

See Also:


Attachments
Patch (15.72 KB, patch)
2011-07-06 06:31 PDT, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-07-06 06:27:51 PDT
Patch to follow.
Comment 1 Pavel Feldman 2011-07-06 06:31:02 PDT
Created attachment 99824 [details]
Patch
Comment 2 Yury Semikhatsky 2011-07-06 08:09:58 PDT
Comment on attachment 99824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99824&action=review

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:295
> +            return false;

should be return;

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:316
> +        var treeElement = this.treeElementFromEvent(event);

There is already _treeElementFromEvent, please leave just one of the methods.

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:392
> +    {   var treeElement = this.treeElementFromEvent(event);

style: var treeElement... should go on the next line
Comment 3 Pavel Feldman 2011-07-06 08:25:56 PDT
Committed r90460: <http://trac.webkit.org/changeset/90460>