Bug 63986 - Date.prototype.toISOString doesn't handle negative years or years > 9999 correctly.
Summary: Date.prototype.toISOString doesn't handle negative years or years > 9999 corr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Minor
Assignee: Mark Hahnenberg
URL:
Keywords:
: 69231 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-07-06 05:19 PDT by Lasse Reichstein Holst Nielsen
Modified: 2012-01-05 20:51 PST (History)
5 users (show)

See Also:


Attachments
Patch (6.14 KB, patch)
2011-07-22 09:42 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lasse Reichstein Holst Nielsen 2011-07-06 05:19:31 PDT
The ES5.1 specification of Date.prototype.toISOString requires the result to be in the format of a Date Time String, which allows an extension of the four-digit ISO year for years outside 0000..9999. I.e., for negative years or years > 9999, the only valid formats are "+yyyyyy" or "-yyyyyy".
The current version outputs dates on the form "10000-01-01T01:01:01.000Z".
Comment 1 Mark Hahnenberg 2011-07-22 09:42:25 PDT
Created attachment 101738 [details]
Patch
Comment 2 Geoffrey Garen 2011-07-22 10:48:39 PDT
Comment on attachment 101738 [details]
Patch

r=me
Comment 3 WebKit Review Bot 2011-07-22 11:01:04 PDT
Comment on attachment 101738 [details]
Patch

Clearing flags on attachment: 101738

Committed r91576: <http://trac.webkit.org/changeset/91576>
Comment 4 WebKit Review Bot 2011-07-22 11:01:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Gavin Barraclough 2012-01-05 20:51:38 PST
*** Bug 69231 has been marked as a duplicate of this bug. ***