Bug 63983 - new-run-webkit-tests uses a 35s timeout for Mac and 6s for all other ports
Summary: new-run-webkit-tests uses a 35s timeout for Mac and 6s for all other ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 34984
  Show dependency treegraph
 
Reported: 2011-07-06 03:21 PDT by Eric Seidel (no email)
Modified: 2011-07-06 03:28 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.04 KB, patch)
2011-07-06 03:22 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (4.34 KB, patch)
2011-07-06 03:24 PDT, Eric Seidel (no email)
xan.lopez: review+
xan.lopez: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-07-06 03:21:07 PDT
new-run-webkit-tests uses a 35s timeout for Mac and 6s for all other ports
Comment 1 Eric Seidel (no email) 2011-07-06 03:22:39 PDT
Created attachment 99806 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-07-06 03:23:25 PDT
The check that MacPort.__init__ was using was wrong, because the option is called time_out_ms, not time-out-ms.  It didn't matter unless someone tried to override the timeout value.
Comment 3 Eric Seidel (no email) 2011-07-06 03:24:38 PDT
Created attachment 99808 [details]
Patch
Comment 4 Xan Lopez 2011-07-06 03:26:49 PDT
Comment on attachment 99808 [details]
Patch

Excellent!
Comment 5 Eric Seidel (no email) 2011-07-06 03:28:30 PDT
Committed r90448: <http://trac.webkit.org/changeset/90448>