Bug 63979 - garden-o-matic shouldn't show flaky tests by default
Summary: garden-o-matic shouldn't show flaky tests by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-06 00:28 PDT by Adam Barth
Modified: 2011-07-06 00:39 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.00 KB, patch)
2011-07-06 00:30 PDT, Adam Barth
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-07-06 00:28:28 PDT
garden-o-matic shouldn't show flaky tests by default
Comment 1 Adam Barth 2011-07-06 00:30:21 PDT
Created attachment 99798 [details]
Patch
Comment 2 Ojan Vafai 2011-07-06 00:35:39 PDT
Comment on attachment 99798 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99798&action=review

> Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:9
> +var kPassingResults = ['PASS'];

Using an array here seems like overkill to me. I think a string would do.

> Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:10
> +var kPassingResults = ['PASS'];
>  var kFailingResults = ['TIMEOUT', 'TEXT', 'CRASH', 'IMAGE','IMAGE+TEXT'];

Should have mentioned in a previous review, you might want to alias these strings, e.g.
var TIMEOUT = 'TIMEOUT';

It will save you pain down the road for when you typo 'TIMEOT'. With the variables, you'll get a nice JS exception right where the problem code is.
Comment 3 Adam Barth 2011-07-06 00:38:58 PDT
var IMAGE+TEXT = 'IMAGE+TEXT';

:(
Comment 4 Adam Barth 2011-07-06 00:39:34 PDT
Committed r90442: <http://trac.webkit.org/changeset/90442>
Comment 5 Adam Barth 2011-07-06 00:39:52 PDT
IMAGE_TEXT it is!