RESOLVED FIXED 63979
garden-o-matic shouldn't show flaky tests by default 
https://bugs.webkit.org/show_bug.cgi?id=63979
Summary garden-o-matic shouldn't show flaky tests by default
Adam Barth
Reported 2011-07-06 00:28:28 PDT
garden-o-matic shouldn't show flaky tests by default
Attachments
Patch (3.00 KB, patch)
2011-07-06 00:30 PDT, Adam Barth 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-07-06 00:30:21 PDT
Created attachment 99798 [details] Patch
Ojan Vafai
Comment 2 2011-07-06 00:35:39 PDT
Comment on attachment 99798 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99798&action=review > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:9 > +var kPassingResults = ['PASS']; Using an array here seems like overkill to me. I think a string would do. > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:10 > +var kPassingResults = ['PASS']; > var kFailingResults = ['TIMEOUT', 'TEXT', 'CRASH', 'IMAGE','IMAGE+TEXT']; Should have mentioned in a previous review, you might want to alias these strings, e.g. var TIMEOUT = 'TIMEOUT'; It will save you pain down the road for when you typo 'TIMEOT'. With the variables, you'll get a nice JS exception right where the problem code is.
Adam Barth
Comment 3 2011-07-06 00:38:58 PDT
var IMAGE+TEXT = 'IMAGE+TEXT'; :(
Adam Barth
Comment 4 2011-07-06 00:39:34 PDT
Committed r90442: <http://trac.webkit.org/changeset/90442>
Adam Barth
Comment 5 2011-07-06 00:39:52 PDT
IMAGE_TEXT it is!
Note You need to log in before you can comment on or make changes to this bug.