Bug 63975 - [EFL] Add Fullscreen API feature
Summary: [EFL] Add Fullscreen API feature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-05 21:31 PDT by Gyuyoung Kim
Modified: 2011-07-06 20:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.05 KB, patch)
2011-07-05 21:33 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Modified Patch (3.25 KB, patch)
2011-07-06 07:32 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-07-05 21:31:57 PDT
I would like to start to implement Fullscreen API for HTML5 Video. This patch is first patch for it. I add feature to OptionEfl.cmake, cmakeconfig.h.cmake as well as adding  RenderFullScreen.cpp, fullscreen.css to WebCore/CMakeLists.txt. However, I don't enable the FULLSCREEN_API yet. I would like to enable it after finishing implementation.
Comment 1 Gyuyoung Kim 2011-07-05 21:33:45 PDT
Created attachment 99789 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-07-06 06:05:35 PDT
From what I understood, if one sets ENABLE_FULLSCREEN_API to ON, the build will fail or things will not work later, right? If so, I prefer to hold this commit until the missing implementation enters the tree.

> ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

More details are welcome here: if you still need to work on the code as you mentioned in the bug report, explain here that this commit only adds the flags and files to the build system.

> Source/WebCore/CMakeLists.txt:1410
> +    ${WEBCORE_DIR}/css/fullscreen.css

Not sorted alphabetically.

> Source/cmake/OptionsEfl.cmake:76
> +WEBKIT_FEATURE(ENABLE_FULLSCREEN_API "Enable the Fullscreen API support" DEFAULT OFF)

"the" not needed
Comment 3 Gyuyoung Kim 2011-07-06 07:32:46 PDT
Created attachment 99829 [details]
Modified Patch

I fix this patch according to your comments. 

>> if one sets ENABLE_FULLSCREEN_API to ON, the build will fail or things will not work later, right? If so, I prefer to hold this commit until the missing implementation enters the tree.
 
If RenderFullScreen.cpp is missed when this feature is enabled on current version, build error happens.  So, though ENABLE_FULLSCREEN_API is turned on, there is no build break on this patch . I'd like to implement remained missing things step by step after landing this patch.
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-07-06 07:42:34 PDT
As long as enabling fullscreen support after this patch enters the tree does not break the build, r+ from my side.
Comment 5 WebKit Review Bot 2011-07-06 20:49:51 PDT
Comment on attachment 99829 [details]
Modified Patch

Clearing flags on attachment: 99829

Committed r90531: <http://trac.webkit.org/changeset/90531>
Comment 6 WebKit Review Bot 2011-07-06 20:49:57 PDT
All reviewed patches have been landed.  Closing bug.