Bug 63975 – [EFL] Add Fullscreen API feature

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

I would like to start to implement Fullscreen API for HTML5 Video. This patch is first patch for it. I add feature to OptionEfl.cmake, cmakeconfig.h.cmake as well as adding  RenderFullScreen.cpp, fullscreen.css to WebCore/CMakeLists.txt. However, I don't enable the FULLSCREEN_API yet. I would like to enable it after finishing implementation.

[Gyuyoung Kim]

Created attachment 99789 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

From what I understood, if one sets ENABLE_FULLSCREEN_API to ON, the build will fail or things will not work later, right? If so, I prefer to hold this commit until the missing implementation enters the tree.

> ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).

More details are welcome here: if you still need to work on the code as you mentioned in the bug report, explain here that this commit only adds the flags and files to the build system.

> Source/WebCore/CMakeLists.txt:1410
> +    ${WEBCORE_DIR}/css/fullscreen.css

Not sorted alphabetically.

> Source/cmake/OptionsEfl.cmake:76
> +WEBKIT_FEATURE(ENABLE_FULLSCREEN_API "Enable the Fullscreen API support" DEFAULT OFF)

"the" not needed

[Gyuyoung Kim]

Created attachment 99829 [details]
Modified Patch

I fix this patch according to your comments. 

>> if one sets ENABLE_FULLSCREEN_API to ON, the build will fail or things will not work later, right? If so, I prefer to hold this commit until the missing implementation enters the tree.
 
If RenderFullScreen.cpp is missed when this feature is enabled on current version, build error happens.  So, though ENABLE_FULLSCREEN_API is turned on, there is no build break on this patch . I'd like to implement remained missing things step by step after landing this patch.

[Raphael Kubo da Costa (:rakuco)]

As long as enabling fullscreen support after this patch enters the tree does not break the build, r+ from my side.

[WebKit Review Bot]

Comment on attachment 99829 [details]
Modified Patch

Clearing flags on attachment: 99829

Committed r90531: <http://trac.webkit.org/changeset/90531>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.