Bug 63974 - DFG JIT virtual call implementation is inefficient
Summary: DFG JIT virtual call implementation is inefficient
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-07-05 21:25 PDT by Filip Pizlo
Modified: 2011-07-05 23:36 PDT (History)
1 user (show)

See Also:

the patch (6.73 KB, patch)
2011-07-05 21:52 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-07-05 21:25:41 PDT
When making a virtual call, only one check is necessary to see if the function needs to be compiled.  Currently, the code does two checks (first, if it's a host, and second, if it needs to be compiled).  The old JIT folded both checks into a query on the number of parameters (which would be negative if the function was neither a host function nor was compiled).  The DFG JIT should have the same optimization.
Comment 1 Filip Pizlo 2011-07-05 21:52:09 PDT
Created attachment 99790 [details]
the patch
Comment 2 WebKit Review Bot 2011-07-05 23:35:56 PDT
Comment on attachment 99790 [details]
the patch

Clearing flags on attachment: 99790

Committed r90437: <http://trac.webkit.org/changeset/90437>
Comment 3 WebKit Review Bot 2011-07-05 23:36:00 PDT
All reviewed patches have been landed.  Closing bug.