RESOLVED FIXED63965
garden-o-matic should understand which tests have unexpected failures 
https://bugs.webkit.org/show_bug.cgi?id=63965
Summary garden-o-matic should understand which tests have unexpected failures
Adam Barth
Reported 2011-07-05 18:42:09 PDT
garden-o-matic should understand which tests have unexpected failures
Attachments
Patch (5.36 KB, patch)
2011-07-05 18:43 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-07-05 18:43:35 PDT
Created attachment 99771 [details] Patch
Eric Seidel (no email)
Comment 2 2011-07-05 18:44:48 PDT
Comment on attachment 99771 [details] Patch I'm not a very good JS reviewer. You owe me some unit testing....
Eric Seidel (no email)
Comment 3 2011-07-05 18:45:08 PDT
Why is our JS style 2-space indent? Does check-webkit-style enforce that?
Adam Barth
Comment 4 2011-07-05 18:45:40 PDT
> Why is our JS style 2-space indent? Does check-webkit-style enforce that? This style matches the code-review.js code. I don't think it's enforced by check-webkit-style.
Ojan Vafai
Comment 5 2011-07-05 18:49:26 PDT
Comment on attachment 99771 [details] Patch Seems fine to me. I'm not familiar with jquery grep, but I'll assume it does what you want. I'd just use "filter" on the array, but I know you luvs ur jquery. :) I should have commented on the previous patch as well, I don't like using a different style for our JS code than our C++/Python code. The benefits are not worth the context switching cost. I'd prefer if we did 4 space indent and open curly on a new line.
Ojan Vafai
Comment 6 2011-07-05 18:49:55 PDT
(In reply to comment #4) > > Why is our JS style 2-space indent? Does check-webkit-style enforce that? > > This style matches the code-review.js code. I don't think it's enforced by check-webkit-style. We should change that as well IMO.
Adam Barth
Comment 7 2011-07-05 18:52:48 PDT
> I should have commented on the previous patch as well, I don't like using a different style for our JS code than our C++/Python code. The benefits are not worth the context switching cost. I'd prefer if we did 4 space indent and open curly on a new line. Python style is a bad match for JavaScript because the JavaScript standard library doesn't match and that's odd. I'll change the style to match our C++ style (moving the curlies and camelCasing the variables, etc).
Adam Barth
Comment 8 2011-07-05 19:32:17 PDT
Comment on attachment 99771 [details] Patch Clearing flags on attachment: 99771 Committed r90428: <http://trac.webkit.org/changeset/90428>
Adam Barth
Comment 9 2011-07-05 19:32:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.