Bug 63964 - Force inlining of simple functions that show up as not being inlined
Summary: Force inlining of simple functions that show up as not being inlined
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Oliver Hunt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-05 18:22 PDT by Oliver Hunt
Modified: 2011-07-05 18:31 PDT (History)
0 users

See Also:


Attachments
Patch (35.18 KB, patch)
2011-07-05 18:24 PDT, Oliver Hunt
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Oliver Hunt 2011-07-05 18:22:04 PDT
Force inlining of simple functions that show up as not being inlined
Comment 1 Oliver Hunt 2011-07-05 18:24:10 PDT
Created attachment 99769 [details]
Patch
Comment 2 Gavin Barraclough 2011-07-05 18:28:57 PDT
Comment on attachment 99769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99769&action=review

> Source/JavaScriptCore/assembler/LinkBuffer.h:251
> +            uint16_t* copySource = reinterpret_cast<uint16_t*>(inData + readPtr);

I kinda think it would be nice to add a couple more asserts, check ing that the points are aligned, and that the regions do not overlap.  But I leave that to your personal taste. r+ either way.
Comment 3 Oliver Hunt 2011-07-05 18:31:20 PDT
Committed r90426: <http://trac.webkit.org/changeset/90426>