RESOLVED FIXED 63957
JSC JIT has code duplication for the handling of call and construct 
https://bugs.webkit.org/show_bug.cgi?id=63957
Summary JSC JIT has code duplication for the handling of call and construct
Filip Pizlo
Reported 2011-07-05 15:15:22 PDT
The JSC JIT compiles code differently depending on whether it's used for a normal call or an object construction. However, even in cases where the compilation code path would be almost entirely identical for the two cases, there is code duplication, particularly in JITStubs.cpp.
Attachments
the patch (17.85 KB, patch)
2011-07-05 15:29 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (fix style) (17.85 KB, patch)
2011-07-05 15:33 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-07-05 15:29:46 PDT
Created attachment 99754 [details] the patch
WebKit Review Bot
Comment 2 2011-07-05 15:31:57 PDT
Attachment 99754 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/jit/JIT.h:249: The parameter name "kind" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 3 2011-07-05 15:33:54 PDT
Created attachment 99755 [details] the patch (fix style)
WebKit Review Bot
Comment 4 2011-07-05 16:18:35 PDT
Comment on attachment 99755 [details] the patch (fix style) Clearing flags on attachment: 99755 Committed r90414: <http://trac.webkit.org/changeset/90414>
WebKit Review Bot
Comment 5 2011-07-05 16:18:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.