Bug 63957 - JSC JIT has code duplication for the handling of call and construct
Summary: JSC JIT has code duplication for the handling of call and construct
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-05 15:15 PDT by Filip Pizlo
Modified: 2011-07-05 16:18 PDT (History)
1 user (show)

See Also:


Attachments
the patch (17.85 KB, patch)
2011-07-05 15:29 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (fix style) (17.85 KB, patch)
2011-07-05 15:33 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-07-05 15:15:22 PDT
The JSC JIT compiles code differently depending on whether it's used for a normal call or an object construction.  However, even in cases where the compilation code path would be almost entirely identical for the two cases, there is code duplication, particularly in JITStubs.cpp.
Comment 1 Filip Pizlo 2011-07-05 15:29:46 PDT
Created attachment 99754 [details]
the patch
Comment 2 WebKit Review Bot 2011-07-05 15:31:57 PDT
Attachment 99754 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/jit/JIT.h:249:  The parameter name "kind" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2011-07-05 15:33:54 PDT
Created attachment 99755 [details]
the patch (fix style)
Comment 4 WebKit Review Bot 2011-07-05 16:18:35 PDT
Comment on attachment 99755 [details]
the patch (fix style)

Clearing flags on attachment: 99755

Committed r90414: <http://trac.webkit.org/changeset/90414>
Comment 5 WebKit Review Bot 2011-07-05 16:18:40 PDT
All reviewed patches have been landed.  Closing bug.