Bug 63943 - Spelling error in v8WebSocket::constructorCallback error
Summary: Spelling error in v8WebSocket::constructorCallback error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows Vista
: P1 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-05 09:08 PDT by Berend-Jan Wever
Modified: 2011-10-13 22:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.94 KB, patch)
2011-10-13 16:18 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (3.17 KB, patch)
2011-10-13 16:20 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Berend-Jan Wever 2011-07-05 09:08:29 PDT 
Adam, I think you misspelled "constructor":

WebKit/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp@53:
        return throwError("DOM object custructor cannot be called as a function.");

Repro/test:
<script>
  try { WebSocket() } catch(e) { document.write(e.message.indexOf('custructor') == -1 ? 'PASS' : 'FAIL:' + e.message);}
</script>
Comment 1 Adam Barth 2011-10-13 16:18:43 PDT 
Created attachment 110922 [details]
Patch
Comment 2 Adam Barth 2011-10-13 16:20:02 PDT 
Created attachment 110924 [details]
Patch
Comment 3 WebKit Review Bot 2011-10-13 22:11:40 PDT 
Comment on attachment 110924 [details]
Patch

Clearing flags on attachment: 110924

Committed r97441: <http://trac.webkit.org/changeset/97441>
Comment 4 WebKit Review Bot 2011-10-13 22:11:44 PDT 
All reviewed patches have been landed.  Closing bug.