Bug 63932 - Web Inspector: add "element state" setting to the styles section title.
: Web Inspector: add "element state" setting to the styles section title.
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-07-05 05:27 PST by
Modified: 2011-07-05 08:35 PST (History)


Attachments
[IMAGE] Draft icon for :active/:hover/:focus toggle. (3.33 KB, image/png)
2011-07-05 05:43 PST, Pavel Feldman
no flags Details
[IMAGE] Looks with patch applied. (21.84 KB, image/png)
2011-07-05 07:18 PST, Pavel Feldman
no flags Details
Patch (18.77 KB, patch)
2011-07-05 07:47 PST, Pavel Feldman
yurys: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-07-05 05:27:14 PST
This is a part of the support for the :hover, :active, etc.
------- Comment #1 From 2011-07-05 05:43:19 PST -------
Created an attachment (id=99706) [details]
[IMAGE] Draft icon for :active/:hover/:focus toggle.
------- Comment #2 From 2011-07-05 07:18:30 PST -------
Created an attachment (id=99714) [details]
[IMAGE] Looks with patch applied.
------- Comment #3 From 2011-07-05 07:47:43 PST -------
Created an attachment (id=99715) [details]
Patch
------- Comment #4 From 2011-07-05 08:17:24 PST -------
(From update of attachment 99715 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=99715&action=review

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:58
> +    var muteEventListener = function(event) { event.stopPropagation(); event.preventDefault(); };

Any point in having this as a standalone var?

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:722
> +        var tr = document.createElement("tr");

a good shortcut:
var tr = table.createChild("tr");
(also appends tr to table)

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:727
> +        tr = document.createElement("tr");

ditto

> Source/WebCore/inspector/front-end/StylesSidebarPane.js:732
> +        this._elementStatePane.appendChild(table);

you could potentially use the same approach for table

> Source/WebCore/inspector/front-end/inspector.css:1775
> +

odd new blank line

> Source/WebCore/inspector/front-end/inspector.css:4556
> +    border-spacing: 0;

You don't need this property here as it applies to tables only

> Source/WebCore/inspector/front-end/inspector.css:4567
> +

extra blank line
------- Comment #5 From 2011-07-05 08:35:36 PST -------
Committed r90397: <http://trac.webkit.org/changeset/90397>