Bug 63931 - WebSocket: Move current WebSocket tests to a new directory
Summary: WebSocket: Move current WebSocket tests to a new directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on:
Blocks: 50099
  Show dependency treegraph
 
Reported: 2011-07-05 05:01 PDT by Yuta Kitamura
Modified: 2011-07-06 01:07 PDT (History)
3 users (show)

See Also:


Attachments
Patch (417.01 KB, patch)
2011-07-05 05:48 PDT, Yuta Kitamura
tkent: review+
yutak: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-07-05 05:01:31 PDT
Create a new subdirectory under http/tests/websocket/tests and move existing WebSocket tests (for the old protocol) to that directory so I can start to put tests for the new protocol.
Comment 1 Yuta Kitamura 2011-07-05 05:48:32 PDT
Created attachment 99707 [details]
Patch

This patch is painfully huge, but what it is doing is just moving files under "LayoutTests/http/tests/websocket/tests/" to a new subdirectory "hixie76/".

Setting cq- because:
- This change probably needs to be committed manually to keep version history.
- It is known that this move breaks at least one test of Chromium's ui_tests (which includes hard-coded path). This needs to be worked around.
Comment 2 Yuta Kitamura 2011-07-05 06:20:48 PDT
Do'h, EWS bots did not like my patch... I don't know how to workaround this.

Mac and win seemed fine when I tested locally. Chromium also seemed fine on all platforms according to the try bots.
Comment 3 Kent Tamura 2011-07-05 17:09:27 PDT
Comment on attachment 99707 [details]
Patch

Setting cq- because:
> - This change probably needs to be committed manually to keep version history.
> - It is known that this move breaks at least one test of Chromium's ui_tests (which includes hard-coded path). This needs to be worked around.

ok, please take care of ui_tests after you land this patch.
Comment 4 Yuta Kitamura 2011-07-06 01:07:03 PDT
Committed r90445: <http://trac.webkit.org/changeset/90445>