[V8][Chromium] Remove use of OwnHandle from V8LocalContext
Created attachment 99677 [details] Patch
Uploaded as per the discussion in Bug 62345.
(In reply to comment #2) > Uploaded as per the discussion in Bug 62345. LGTM. Just to note, it is still unclear why OwnHandle does not do the job - I will investigate this more. > Source/WebCore/bindings/v8/V8Utilities.cpp:52 > + : m_context(v8::Context::New()) It does not matter one bit currently, but logically we want to do any V8 operations (including newing up the context) after we ensure that V8BindingPerIsolateData is initialized.
> It does not matter one bit currently, but logically we want to do any V8 operations (including newing up the context) after we ensure that V8BindingPerIsolateData is initialized. So you're saying we shouldn't do this in the initializer list?
Comment on attachment 99677 [details] Patch Clearing flags on attachment: 99677 Committed r90407: <http://trac.webkit.org/changeset/90407>
All reviewed patches have been landed. Closing bug.
(In reply to comment #4) > > It does not matter one bit currently, but logically we want to do any V8 operations (including newing up the context) after we ensure that V8BindingPerIsolateData is initialized. > > So you're saying we shouldn't do this in the initializer list? In the Grand Scheme Of Things (TM), yes, but it does not matter as of today.