Bug 63923 - WebKit::PluginView::m_pendingURLRequestsTimer should use RunLoop::current()
Summary: WebKit::PluginView::m_pendingURLRequestsTimer should use RunLoop::current()
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-05 01:07 PDT by jaebok.lee
Modified: 2012-07-31 21:49 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jaebok.lee 2011-07-05 01:07:18 PDT 
I am using WebKit2 with ProcessModel::ProcessModelSharedSecondaryThread.

When I use Plugin, a crash was invoked.

I found that WebKit::PluginView::m_pendingURLRequestsTimer use RunLoop::main().

I think RunLoop::current() is right because WebKit::PluginView should work in WebProcess context.


Please check this point.
Comment 1 Sam Weinig 2011-07-05 11:09:51 PDT 
ProcessModelSharedSecondaryThread is currently not expected to work, there are numerous issues like this one lurking around.
Comment 2 Anders Carlsson 2011-07-05 11:11:42 PDT 
(In reply to comment #0)
> I am using WebKit2 with ProcessModel::ProcessModelSharedSecondaryThread.
> 
> When I use Plugin, a crash was invoked.
> 
> I found that WebKit::PluginView::m_pendingURLRequestsTimer use RunLoop::main().
> 
> I think RunLoop::current() is right because WebKit::PluginView should work in WebProcess context.
> 
> 
> Please check this point.

I think it should be I think WebProcess::shared().runLoop().
Comment 3 jaebok.lee 2011-07-08 01:18:01 PDT 
When do you expect it works?


(In reply to comment #1)
> ProcessModelSharedSecondaryThread is currently not expected to work, there are numerous issues like this one lurking around.