RESOLVED WONTFIX Bug 63920
Guarding header file inclusion in proper compilation flags. 
https://bugs.webkit.org/show_bug.cgi?id=63920
Summary Guarding header file inclusion in proper compilation flags.
Nayan Kumar K
Reported 2011-07-04 17:53:12 PDT
Some of the header file inclusion inside Source/WebCore/bindings/v8/ are not guarded properly with proper conditional compilation flag. For example, in Source/WebCore/bindings/v8/V8DOMWrapper.cpp file, "V8FileReader.h" file is included directly, whereas it should ideally get included under #if ENABLE(BLOB) flag, as V8FileReader.h gets generated only when BLOB is enabled (in file Sources/WebCore/fileapi/FileReader.idl) These need to be fixed.
Attachments
Patch (5.12 KB, patch)
2011-07-04 18:01 PDT, Nayan Kumar K 		no flags
DetailsFormatted DiffDiff
Patch (5.30 KB, patch)
2011-07-04 18:12 PDT, Nayan Kumar K 		ap: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nayan Kumar K
Comment 1 2011-07-04 18:01:57 PDT
Created attachment 99661 [details] Patch
WebKit Review Bot
Comment 2 2011-07-04 18:05:34 PDT
Comment on attachment 99661 [details] Patch Attachment 99661 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8979972
Nayan Kumar K
Comment 3 2011-07-04 18:12:27 PDT
Created attachment 99662 [details] Patch
Alexey Proskuryakov
Comment 4 2011-07-05 00:10:23 PDT
Comment on attachment 99662 [details] Patch These files should always be generated, and they should have #if checks inside. Uglifying every .cpp file with tons of #if checks makes no sense.
Note You need to log in before you can comment on or make changes to this bug.