Bug 63915 - NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
Summary: NP_RemoveProperty is not called back by Safari when delete npObject.prop is e...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-04 12:48 PDT by Anders Carlsson
Modified: 2011-07-05 01:25 PDT (History)
2 users (show)

See Also:


Attachments
Patch (15.88 KB, patch)
2011-07-04 12:54 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2011-07-04 12:48:45 PDT
NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
Comment 1 Anders Carlsson 2011-07-04 12:54:14 PDT
Created attachment 99650 [details]
Patch
Comment 2 Anders Carlsson 2011-07-04 12:59:01 PDT
Committed r90372: <http://trac.webkit.org/changeset/90372>
Comment 3 Zoltan Herczeg 2011-07-04 13:18:42 PDT
Killed the Qt bot:

/ramdisk/qt-linux-release/build/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp: In member function ‘bool NPRuntimeRemoveProperty::TestObject::getProperty(void*, NPVariant*)’:
/ramdisk/qt-linux-release/build/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:64: error: ‘strlen’ was not declared in this scope
/ramdisk/qt-linux-release/build/Tools/DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:64: error: too many initializers for ‘NPString’

Probably #include <string.h> could solve this.

Are you aware of this?
Comment 4 Anders Carlsson 2011-07-04 13:22:29 PDT
(In reply to comment #3)

> Are you aware of this?

Fixed in http://trac.webkit.org/changeset/90374.
Comment 5 Balazs Kelemen 2011-07-05 01:25:42 PDT
Let me quote a half sentence from the Changelog:
"... there doesn't seem to be a way to make a WebKit2 specific test."

This could be fixed by adding wk2 specific results to the Layouttests/platform/wk2 directory and teach owrt and nwrt to use them.
I created a bug for this: https://bugs.webkit.org/show_bug.cgi?id=63926