Bug 63909 - Remove virtual functions from StyleImage.
Summary: Remove virtual functions from StyleImage.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-04 07:53 PDT by Tamas Czene
Modified: 2011-07-07 04:18 PDT (History)
5 users (show)

See Also:


Attachments
Remove virtual functions from StyleImage (5.42 KB, patch)
2011-07-04 08:13 PDT, Tamas Czene
no flags Details | Formatted Diff | Diff
Remove virtual functions from StyleImage (5.45 KB, patch)
2011-07-05 01:10 PDT, Tamas Czene
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tamas Czene 2011-07-04 07:53:20 PDT
We can remove the virtual "isChachedImage, isPendingImage, isGeneratedImage" functions to speed up the StyleImage part of WebKit.
Some profile data shows this part is significant, especially in small CSS-based sites.
Removing the virtual functions - removing the calls - makes a small performance progression on this part.

We measured around 1% speed up on several sites like: bing.com , youtube.com
Comment 1 Tamas Czene 2011-07-04 08:13:12 PDT
Created attachment 99632 [details]
Remove virtual functions from StyleImage
Comment 2 Tamas Czene 2011-07-05 01:10:48 PDT
Created attachment 99675 [details]
Remove virtual functions from StyleImage
Comment 3 Simon Fraser (smfr) 2011-07-05 08:09:04 PDT
Comment on attachment 99675 [details]
Remove virtual functions from StyleImage

View in context: https://bugs.webkit.org/attachment.cgi?id=99675&action=review

> Source/WebCore/ChangeLog:10
> +        Some profile data shows this part is significant, especially in small CSS-based sites.
> +        Removing the virtual functions - removing the calls - makes a small performance progression on this part.

You should put more information in the bug about your performance investigations. What sites did you test? What as the measured gain? What stack traces show time in these methods?
Comment 4 WebKit Review Bot 2011-07-05 09:07:47 PDT
Comment on attachment 99675 [details]
Remove virtual functions from StyleImage

Clearing flags on attachment: 99675

Committed r90399: <http://trac.webkit.org/changeset/90399>
Comment 5 WebKit Review Bot 2011-07-05 09:07:52 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Tamas Czene 2011-07-07 04:18:25 PDT
Generally the effect of the patch is only measurable on small sites.
Examples (Methanol results): 
bing.com  2,6% 
wordpress.org 5,7%