Bug 63900 - [Qt] Fix Qt5 build
Summary: [Qt] Fix Qt5 build
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-04 05:39 PDT by Peter Varga
Modified: 2011-07-05 01:25 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch (10.23 KB, patch)
2011-07-04 05:43 PDT, Peter Varga
no flags Details | Formatted Diff | Diff
proposed patch v1.1 (10.23 KB, patch)
2011-07-04 05:58 PDT, Peter Varga
hausmann: review-
hausmann: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Varga 2011-07-04 05:39:21 PDT
The compiling of QtWebKit with qtbase-staging (git://gitorious.org/+qt-developers/qt/qtbase-staging.git) fails since this change:
http://trac.webkit.org/changeset/90341

It seems the QUrl::topLevelDomain() function hasn't been added to the Qt-5 version. I think we should change the guards in the QtWebKit to 
allow the "third-party cookie stuff" just in case of using Qt-4.8 while the QURL::topLevelDomain() is missing from the Qt-5.
Comment 1 Peter Varga 2011-07-04 05:43:57 PDT
Created attachment 99615 [details]
proposed patch
Comment 2 Peter Varga 2011-07-04 05:58:14 PDT
Created attachment 99618 [details]
proposed patch v1.1

Fix ChangeLog.
Comment 3 Simon Hausmann 2011-07-04 06:01:31 PDT
Hang on, Peter is merging the change from Qt 4.8 to qtbase-staging
Comment 4 Simon Hausmann 2011-07-04 06:11:33 PDT
Hmm, topLevelDomain() is in qtbase:

https://qt.gitorious.org/qt/qtbase/blobs/master/src/corelib/io/qurl.h#line185
Comment 5 Simon Hausmann 2011-07-04 06:18:20 PDT
Comment on attachment 99618 [details]
proposed patch v1.1

Conclusion: qtbase-staging is obsolete, use qtbase.git :)
Comment 6 Simon Hausmann 2011-07-05 01:25:32 PDT
House keeping :)