Bug 63866 - DFG JIT - implement instanceof
Summary: DFG JIT - implement instanceof
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-02 15:32 PDT by Gavin Barraclough
Modified: 2011-07-02 16:08 PDT (History)
1 user (show)

See Also:


Attachments
The patch (15.51 KB, patch)
2011-07-02 15:36 PDT, Gavin Barraclough
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-07-02 15:32:02 PDT
Add ops CheckHasInstance & InstanceOf to implement bytecodes op_check_has_instance & op_instanceof.
Comment 1 Gavin Barraclough 2011-07-02 15:36:02 PDT
Created attachment 99562 [details]
The patch
Comment 2 WebKit Review Bot 2011-07-02 15:37:15 PDT
Attachment 99562 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGJITCompiler.h:225:  Missing space inside { }.  [whitespace/braces] [5]
Source/JavaScriptCore/dfg/DFGOperations.h:64:  The parameter name "value" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Gavin Barraclough 2011-07-02 16:08:39 PDT
Fixed in r90324.