WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
63854
Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
https://bugs.webkit.org/show_bug.cgi?id=63854
Summary
Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests...
Adam Barth
Reported
2011-07-01 16:41:01 PDT
Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
Attachments
Patch
(4.17 KB, patch)
2011-07-01 16:41 PDT
,
Adam Barth
dpranke
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-07-01 16:41:39 PDT
Created
attachment 99537
[details]
Patch
Dirk Pranke
Comment 2
2011-07-01 16:44:35 PDT
Comment on
attachment 99537
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=99537&action=review
> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:263 > + if logText.find("Collecting tests ...") >= 0:
Might be nice if NRWT had a slightly more obvious and reliable banner string to grep for ... maybe we should add a "Running new-run-webkit-tests" when we're printing the configuration or something. Not terribly important, though.
Adam Barth
Comment 3
2011-07-01 16:45:31 PDT
Committed
r90298
: <
http://trac.webkit.org/changeset/90298
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug