Bug 63854 - Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
Summary: Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-01 16:41 PDT by Adam Barth
Modified: 2011-07-01 16:45 PDT (History)
2 users (show)

See Also:


Attachments
Patch (4.17 KB, patch)
2011-07-01 16:41 PDT, Adam Barth
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-07-01 16:41:01 PDT
Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
Comment 1 Adam Barth 2011-07-01 16:41:39 PDT
Created attachment 99537 [details]
Patch
Comment 2 Dirk Pranke 2011-07-01 16:44:35 PDT
Comment on attachment 99537 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99537&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:263
> +        if logText.find("Collecting tests ...") >= 0:

Might be nice if NRWT had a slightly more obvious and reliable banner string to grep for ... maybe we should add a "Running new-run-webkit-tests" when we're printing the configuration or something. Not terribly important, though.
Comment 3 Adam Barth 2011-07-01 16:45:31 PDT
Committed r90298: <http://trac.webkit.org/changeset/90298>