Bug 63853 - [GTK] editing/selection/directionality-after-undo-replace.html is failing
Summary: [GTK] editing/selection/directionality-after-undo-replace.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-01 16:11 PDT by Ryosuke Niwa
Modified: 2015-05-07 17:48 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2011-07-01 18:10 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-07-01 16:11:02 PDT
editing/selection/directionality-after-undo-replace.html	 has been failing since it was checked.
Comment 1 Martin Robinson 2011-07-01 16:28:52 PDT
Thanks for filling this bug. The issue here seems to be that there are so many leapForwards that the test is exceeding the double-click timeout on GTK+. This change causes the test to start passing:

--- a/LayoutTests/editing/selection/directionality-after-undo-replace.html
+++ b/LayoutTests/editing/selection/directionality-after-undo-replace.html
@@ -23,12 +23,11 @@ if (window.layoutTestController) {
         var test = document.getElementById('target');
         eventSender.mouseMoveTo(target.offsetLeft + target.offsetWidth / 2, target.offsetTop + target.offsetHeight / 2);
         eventSender.mouseDown();
-        eventSender.leapForward(200);
         eventSender.mouseUp();
 
         eventSender.leapForward(200);
+
         eventSender.mouseDown();
-        eventSender.leapForward(200);
         eventSender.mouseUp();
 
         document.execCommand('InsertText', false, 'a');
Comment 2 Ryosuke Niwa 2011-07-01 18:10:31 PDT
Created attachment 99543 [details]
Patch
Comment 3 WebKit Review Bot 2011-07-01 19:35:05 PDT
Comment on attachment 99543 [details]
Patch

Clearing flags on attachment: 99543

Committed r90309: <http://trac.webkit.org/changeset/90309>
Comment 4 WebKit Review Bot 2011-07-01 19:35:09 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Ryosuke Niwa 2011-07-01 22:02:12 PDT
This might be related to https://bugs.webkit.org/show_bug.cgi?id=63440.
Comment 7 Ryosuke Niwa 2011-07-01 22:02:48 PDT
It's certainly related to https://bugs.webkit.org/show_bug.cgi?id=63611.
Comment 8 Abhishek Arya 2011-07-01 22:05:38 PDT
That is awesome!!, We can get to the root cause and have more inspiration to fix this. Fixing this might fix many textiterator read crashes.
Comment 9 Martin Robinson 2015-05-07 17:48:48 PDT
This seems okay now on GTK+.