Bug 63851 – Crash when loading a document in an editable WebView that has a subframe with an unstyled body

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Adele Peterson]

Crash when loading a document in an editable WebView that has a subframe with a body element with no style

Unfortunately, there's no way for me to test this in Safari, and I was unable to get this to crash in DumpRenderTree.

This patch fixes two problems:
1) In Editor::applyEditingStyleToElement, we assert that there element has style, but in this case I ran into, it did not.  So I added an early return here.
2) In -[WebHTMLRepresentation finishedLoadingWithDataSource:], instead of applying the desirable editing style to any body element, only do it for the main frame.  There's no need to apply break-word, space, and after-white-space properties to subframes in the editable document.

[Adele Peterson]

Created attachment 99528 [details]
patch

[Darin Adler]

Comment on attachment 99528 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99528&action=review

> Source/WebCore/editing/Editor.cpp:2893
>      CSSStyleDeclaration* style = element->style();
>      ASSERT(style);
> +    if (!style)
> +        return;

This change seems OK, but I’m not sure why it’s needed.

> Source/WebKit/mac/WebView/WebHTMLRepresentation.mm:223
> +    if (([webView mainFrame] == webFrame) && [webView isEditable])

No need for the parentheses here.

[Adele Peterson]

Comment on attachment 99528 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99528&action=review

>> Source/WebCore/editing/Editor.cpp:2893
>> +        return;
> 
> This change seems OK, but I’m not sure why it’s needed.

Although I couldn't think of specific cases, it seems plausible there would be other situations where there's no style.

>> Source/WebKit/mac/WebView/WebHTMLRepresentation.mm:223
>> +    if (([webView mainFrame] == webFrame) && [webView isEditable])
> 
> No need for the parentheses here.

Will remove.

[Eric Seidel (no email)]

Attachment 99528 [details] was posted by a committer and has review+, assigning to Adele Peterson for commit.

[Adele Peterson]

Ugh, I forgot to resolve this bug, but I did commit this shortly after the review:  http://trac.webkit.org/changeset/90290

Sorry about that!