Bug 63839 - buildbot needs to understand whether NRWT exited early after having too many failures
Summary: buildbot needs to understand whether NRWT exited early after having too many ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 34984
  Show dependency treegraph
 
Reported: 2011-07-01 13:30 PDT by WebKit Review Bot
Modified: 2011-07-05 16:16 PDT (History)
3 users (show)

See Also:


Attachments
Patch (19.89 KB, patch)
2011-07-05 15:05 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-07-01 13:30:26 PDT
buildbot needs to understand whether NRWT exited early after having too many failures
Requested by abarth on #webkit.
Comment 1 Eric Seidel (no email) 2011-07-05 13:23:19 PDT
The results.json needs to include that information too.
Comment 2 Adam Barth 2011-07-05 14:48:33 PDT
> The results.json needs to include that information too.

It might already.  If not, it's easy to add.
Comment 3 Eric Seidel (no email) 2011-07-05 15:05:24 PDT
Created attachment 99750 [details]
Patch
Comment 4 Adam Barth 2011-07-05 15:25:36 PDT
Comment on attachment 99750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99750&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:212
> +    results['interrupted'] = interrupted  # Does results.html have enough information to compute this itself? (by checking total number of results vs. total number of tests?)

I doubt it.  You can restrict the test set in a bunch of different ways.
Comment 5 Ojan Vafai 2011-07-05 15:48:12 PDT
Comment on attachment 99750 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99750&action=review

> Tools/ChangeLog:15
> +        itself.  It's possible Ojan could come up with a better fix.

Nope. This is roughly how I would have done it.

>> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:212
>> +    results['interrupted'] = interrupted  # Does results.html have enough information to compute this itself? (by checking total number of results vs. total number of tests?)
> 
> I doubt it.  You can restrict the test set in a bunch of different ways.

Agree.
Comment 6 WebKit Review Bot 2011-07-05 16:16:31 PDT
Comment on attachment 99750 [details]
Patch

Clearing flags on attachment: 99750

Committed r90413: <http://trac.webkit.org/changeset/90413>
Comment 7 WebKit Review Bot 2011-07-05 16:16:37 PDT
All reviewed patches have been landed.  Closing bug.