Bug 63831 – [Qt] Fix build when --media-stream flag is used

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Danilo de Paula]

Fixing Qt port build when media-stream flag is enabled.

[Danilo de Paula]

Created attachment 99505 [details]
diff adding the new rule on features.pri

Forgot the patch

[WebKit Review Bot]

Attachment 99505 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Danilo de Paula]

Created attachment 99507 [details]
mediastreamflag.patch

[Igor Trindade Oliveira]

You should remove the "No new tests" line because Commit Bot can complain. And add [Qt] tag in the beginning of commit title.

(In reply to comment #3)
> Created an attachment (id=99507) [details]
> mediastreamflag.patch

[Ademar Reis]

from build-webkit --help:

  --[no-]media-stream               Toggle Media Stream API support (implies Blob support, currently Chromium and GTK only) (default: 0)

Do you get anything useful on Qt with --media-stream? If yes, then maybe your patch should also remove this note from build-webkit.

[Danilo de Paula]

Created attachment 99519 [details]
mediastream.patch

Fixing commit message.

[WebKit Review Bot]

The commit-queue encountered the following flaky tests while processing attachment 99519 [details]:

http/tests/local/blob/send-sliced-data-blob.html bug 63598 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Review Bot]

Comment on attachment 99519 [details]
mediastream.patch

Clearing flags on attachment: 99519

Committed r90359: <http://trac.webkit.org/changeset/90359>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.