Bug 63831 - [Qt] Fix build when --media-stream flag is used
Summary: [Qt] Fix build when --media-stream flag is used
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-07-01 12:32 PDT by Danilo Cesar Lemes de Paula
Modified: 2011-07-04 03:57 PDT (History)
3 users (show)

See Also:


Attachments
diff adding the new rule on features.pri (1.94 KB, patch)
2011-07-01 12:33 PDT, Danilo Cesar Lemes de Paula
no flags Details | Formatted Diff | Diff
mediastreamflag.patch (1.99 KB, patch)
2011-07-01 12:40 PDT, Danilo Cesar Lemes de Paula
no flags Details | Formatted Diff | Diff
mediastream.patch (1.96 KB, patch)
2011-07-01 14:06 PDT, Danilo Cesar Lemes de Paula
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Danilo Cesar Lemes de Paula 2011-07-01 12:32:27 PDT
Fixing Qt port build when media-stream flag is enabled.
Comment 1 Danilo Cesar Lemes de Paula 2011-07-01 12:33:54 PDT
Created attachment 99505 [details]
diff adding the new rule on features.pri

Forgot the patch
Comment 2 WebKit Review Bot 2011-07-01 12:36:22 PDT
Attachment 99505 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Danilo Cesar Lemes de Paula 2011-07-01 12:40:48 PDT
Created attachment 99507 [details]
mediastreamflag.patch
Comment 4 Igor Trindade Oliveira 2011-07-01 13:02:33 PDT
You should remove the "No new tests" line because Commit Bot can complain. And add [Qt] tag in the beginning of commit title.

(In reply to comment #3)
> Created an attachment (id=99507) [details]
> mediastreamflag.patch
Comment 5 Ademar Reis 2011-07-01 13:13:21 PDT
from build-webkit --help:

  --[no-]media-stream               Toggle Media Stream API support (implies Blob support, currently Chromium and GTK only) (default: 0)

Do you get anything useful on Qt with --media-stream? If yes, then maybe your patch should also remove this note from build-webkit.
Comment 6 Danilo Cesar Lemes de Paula 2011-07-01 14:06:14 PDT
Created attachment 99519 [details]
mediastream.patch

Fixing commit message.
Comment 7 WebKit Review Bot 2011-07-04 03:55:37 PDT
The commit-queue encountered the following flaky tests while processing attachment 99519 [details]:

http/tests/local/blob/send-sliced-data-blob.html bug 63598 (author: kinuko@chromium.org)
The commit-queue is continuing to process your patch.
Comment 8 WebKit Review Bot 2011-07-04 03:57:00 PDT
Comment on attachment 99519 [details]
mediastream.patch

Clearing flags on attachment: 99519

Committed r90359: <http://trac.webkit.org/changeset/90359>
Comment 9 WebKit Review Bot 2011-07-04 03:57:04 PDT
All reviewed patches have been landed.  Closing bug.