Bug 63827 - cleanup of flexbox and marquee data naming in StyleRareNonInheritedData
Summary: cleanup of flexbox and marquee data naming in StyleRareNonInheritedData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-01 12:12 PDT by Tony Chang
Modified: 2011-07-01 13:30 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.82 KB, patch)
2011-07-01 12:13 PDT, Tony Chang 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-07-01 12:12:28 PDT 
cleanup of flexbox and marquee data naming in StyleRareNonInheritedData
Comment 1 Tony Chang 2011-07-01 12:13:40 PDT 
Created attachment 99501 [details]
Patch
Comment 2 Tony Chang 2011-07-01 12:15:35 PDT 
stylebot is going to complain, but almost all the params in RenderStyle.h are single letter.
Comment 3 WebKit Review Bot 2011-07-01 12:17:37 PDT 
Attachment 99501 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/rendering/style/RenderStyle.h:1034:  l is incorrectly named. Don't use the single letter 'l' as an identifier name.  [readability/naming] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Tony Chang 2011-07-01 13:30:05 PDT 
Committed r90271: <http://trac.webkit.org/changeset/90271>