RESOLVED FIXED 63827
cleanup of flexbox and marquee data naming in StyleRareNonInheritedData 
https://bugs.webkit.org/show_bug.cgi?id=63827
Summary cleanup of flexbox and marquee data naming in StyleRareNonInheritedData
Tony Chang
Reported 2011-07-01 12:12:28 PDT
cleanup of flexbox and marquee data naming in StyleRareNonInheritedData
Attachments
Patch (13.82 KB, patch)
2011-07-01 12:13 PDT, Tony Chang 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-07-01 12:13:40 PDT
Created attachment 99501 [details] Patch
Tony Chang
Comment 2 2011-07-01 12:15:35 PDT
stylebot is going to complain, but almost all the params in RenderStyle.h are single letter.
WebKit Review Bot
Comment 3 2011-07-01 12:17:37 PDT
Attachment 99501 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/rendering/style/RenderStyle.h:1034: l is incorrectly named. Don't use the single letter 'l' as an identifier name. [readability/naming] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tony Chang
Comment 4 2011-07-01 13:30:05 PDT
Committed r90271: <http://trac.webkit.org/changeset/90271>
Note You need to log in before you can comment on or make changes to this bug.