Currently after receiving EndOfMedia event Media Player goes into HAVE_ENOUGH_DATA state. After EndOfMedia event has been received the current playback position should never advance, however, HAVE_ENOUGH_DATA and HAVE_FUTURE_DATA states gives a false perception that there is more data to be played. This patch corrects this problem in order to conform with spec here :http://dev.w3.org/html5/spec/Overview.html#dom-media-have_current_data
Created attachment 99510 [details] This fixes network state after EndOfMedia event
Attachment 99510 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:517: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 99510 [details] This fixes network state after EndOfMedia event View in context: https://bugs.webkit.org/attachment.cgi?id=99510&action=review Otherwise it is fine to me. > Source/WebCore/ChangeLog:5 > + MediaPlayer in QtWebkit does not follow the spec for EndOfMedia State Wrong title.I changed the bug title myself. > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) This is wrong. Does some media tests are passing (even if they all skip for now, you can run them and ignore the skip list and see). >> Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:517 > > Tab found; better to use spaces [whitespace/tab] [1] Needs to be fixed.
Created attachment 101627 [details] This fixes network state after EndOfMedia event
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.