On windows, TestWebKitAPI build is a part of general WebKit build, just like DumpRenderTree. Windows buildbots are not set up to be able to build anything in WebKit
Created attachment 99488 [details] Fix: adds --skipbuild parameter to run-api-tests and sets that parameter on win bot
Comment on attachment 99488 [details] Fix: adds --skipbuild parameter to run-api-tests and sets that parameter on win bot View in context: https://bugs.webkit.org/attachment.cgi?id=99488&action=review > Tools/Scripts/run-api-tests:54 > +my $skipbuild = 0; I'd call this $skipBuild. > Tools/Scripts/run-api-tests:62 > + --skipbuild Do not build unit tests prior to running I think our normal spelling for this is --skip-build. Though I tend to prefer the --[no-]build style that old-run-webkit-tests uses.
Created attachment 99496 [details] CR feedback
Comment on attachment 99496 [details] CR feedback View in context: https://bugs.webkit.org/attachment.cgi?id=99496&action=review > Tools/Scripts/run-api-tests:62 > + --no-build Do not build unit tests prior to running The description here doesn't line up with the others. > Tools/Scripts/run-api-tests:69 > + 'no-build' => \$noBuild even better would be to specify this as: my $build = 1; --[no-]build Build unit tests prior to running (default: $build) 'build!' => \$build That will cause --build and --no-build to work as expected.
Created attachment 99518 [details] More CR feedback: better options management
Comment on attachment 99518 [details] More CR feedback: better options management Clearing flags on attachment: 99518 Committed r90278: <http://trac.webkit.org/changeset/90278>
All reviewed patches have been landed. Closing bug.