Bug 63818 - Test bots shouldn't attempt to build TestWebKitAPI on Windows
Summary: Test bots shouldn't attempt to build TestWebKitAPI on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-01 11:04 PDT by Dmitry Lomov
Modified: 2011-07-01 14:44 PDT (History)
4 users (show)

See Also:


Attachments
Fix: adds --skipbuild parameter to run-api-tests and sets that parameter on win bot (2.39 KB, patch)
2011-07-01 11:12 PDT, Dmitry Lomov
aroben: review-
aroben: commit-queue-
Details | Formatted Diff | Diff
CR feedback (2.38 KB, patch)
2011-07-01 11:57 PDT, Dmitry Lomov
aroben: review-
aroben: commit-queue-
Details | Formatted Diff | Diff
More CR feedback: better options management (2.46 KB, patch)
2011-07-01 13:58 PDT, Dmitry Lomov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Lomov 2011-07-01 11:04:56 PDT
On windows, TestWebKitAPI build is a part of general WebKit build, just like DumpRenderTree.
Windows buildbots are not set up to be able to build anything in WebKit
Comment 1 Dmitry Lomov 2011-07-01 11:12:56 PDT
Created attachment 99488 [details]
Fix: adds --skipbuild parameter to run-api-tests and sets that parameter on win bot
Comment 2 Adam Roben (:aroben) 2011-07-01 11:15:19 PDT
Comment on attachment 99488 [details]
Fix: adds --skipbuild parameter to run-api-tests and sets that parameter on win bot 

View in context: https://bugs.webkit.org/attachment.cgi?id=99488&action=review

> Tools/Scripts/run-api-tests:54
> +my $skipbuild = 0;

I'd call this $skipBuild.

> Tools/Scripts/run-api-tests:62
> +  --skipbuild           Do not build unit tests prior to running

I think our normal spelling for this is --skip-build. Though I tend to prefer the --[no-]build style that old-run-webkit-tests uses.
Comment 3 Dmitry Lomov 2011-07-01 11:57:15 PDT
Created attachment 99496 [details]
CR feedback
Comment 4 Adam Roben (:aroben) 2011-07-01 12:06:49 PDT
Comment on attachment 99496 [details]
CR feedback

View in context: https://bugs.webkit.org/attachment.cgi?id=99496&action=review

> Tools/Scripts/run-api-tests:62
> +  --no-build           Do not build unit tests prior to running

The description here doesn't line up with the others.

> Tools/Scripts/run-api-tests:69
> +    'no-build' => \$noBuild

even better would be to specify this as:

my $build = 1;

--[no-]build    Build unit tests prior to running (default: $build)

'build!' => \$build

That will cause --build and --no-build to work as expected.
Comment 5 Dmitry Lomov 2011-07-01 13:58:20 PDT
Created attachment 99518 [details]
More CR feedback: better options management
Comment 6 WebKit Review Bot 2011-07-01 14:44:16 PDT
Comment on attachment 99518 [details]
More CR feedback: better options management

Clearing flags on attachment: 99518

Committed r90278: <http://trac.webkit.org/changeset/90278>
Comment 7 WebKit Review Bot 2011-07-01 14:44:20 PDT
All reviewed patches have been landed.  Closing bug.