RESOLVED FIXED 63815
REGRESSION (r90229): webkit-patch rollout and sheriffbot rollout are broken 
https://bugs.webkit.org/show_bug.cgi?id=63815
Summary REGRESSION (r90229): webkit-patch rollout and sheriffbot rollout are broken
Adam Roben (:aroben)
Reported 2011-07-01 09:36:59 PDT
REGRESSION (r90229): webkit-patch rollout and sheriffbot rollout are broken
Attachments
Patch (3.84 KB, patch)
2011-07-01 09:40 PDT, Adam Roben (:aroben) 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-07-01 09:40:01 PDT
Created attachment 99483 [details] Patch
Daniel Bates
Comment 2 2011-07-01 09:50:49 PDT
Comment on attachment 99483 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99483&action=review > Tools/Scripts/webkitpy/common/checkout/changelog.py:181 > def update_with_unreviewed_message(self, message): Should we rename this method?
Adam Roben (:aroben)
Comment 3 2011-07-01 09:53:09 PDT
Comment on attachment 99483 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99483&action=review >> Tools/Scripts/webkitpy/common/checkout/changelog.py:181 >> def update_with_unreviewed_message(self, message): > > Should we rename this method? The name isn't that great, but it's no worse than it was before. We could probably come up with a better one.
Adam Roben (:aroben)
Comment 4 2011-07-01 09:55:02 PDT
Committed r90239: <http://trac.webkit.org/changeset/90239>
Eric Seidel (no email)
Comment 5 2011-07-01 11:23:01 PDT
Did you check for any other code in ChagneLogs.py which might need updating?
Adam Roben (:aroben)
Comment 6 2011-07-01 12:02:24 PDT
(In reply to comment #5) > Did you check for any other code in ChagneLogs.py which might need updating? I just checked now and I don't think there's anything else that needs to be changed.
Note You need to log in before you can comment on or make changes to this bug.