RESOLVED FIXED 63814
Fix clang build error in JITOpcodes32_64.cpp 
https://bugs.webkit.org/show_bug.cgi?id=63814
Summary Fix clang build error in JITOpcodes32_64.cpp
David Kilzer (:ddkilzer)
Reported 2011-07-01 09:16:42 PDT
JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:9-741:35}: error: operator '?:' has lower precedence than '+'; '+' will be evaluated first [-Werror,-Wparentheses,3] map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0); ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36: note: place parentheses around the '+' expression to silence this warning [3] map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0); ^ ( ) fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:9-741:9}:"(" fix-it:"JavaScriptCore/jit/JITOpcodes32_64.cpp":{741:35-741:35}:")" JavaScriptCore/jit/JITOpcodes32_64.cpp:741:36:{741:28-741:94}: note: place parentheses around the '?:' expression to evaluate it first [3] map(m_bytecodeOffset + dynamic ? OPCODE_LENGTH(op_resolve_global_dynamic) : OPCODE_LENGTH(op_resolve_global), dst, regT1, regT0); ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.
Attachments
Patch (4.90 KB, patch)
2011-07-01 09:21 PDT, David Kilzer (:ddkilzer) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2011-07-01 09:20:37 PDT
Committed r90232: <http://trac.webkit.org/changeset/90232>
David Kilzer (:ddkilzer)
Comment 2 2011-07-01 09:21:26 PDT
Created attachment 99482 [details] Patch
Darin Adler
Comment 3 2011-07-01 09:26:33 PDT
Looks to me like clang correctly spotted a programming error here, so there was a symptom of this too.
David Kilzer (:ddkilzer)
Comment 4 2011-07-01 09:45:50 PDT
This code was originally introduced in r58991 in JavaScriptCore/jit/JITOpcodes.cpp. <http://trac.webkit.org/changeset/58991>
Alexey Proskuryakov
Comment 5 2011-07-01 10:32:37 PDT
How could this be landed without review, and without a regression test?
Alexey Proskuryakov
Comment 6 2011-07-01 10:33:32 PDT
I have an answer to my question - probably because it was originally believed that it's only a build fix.
David Kilzer (:ddkilzer)
Comment 7 2011-07-01 13:48:00 PDT
<rdar://problem/9713309>
Note You need to log in before you can comment on or make changes to this bug.