Bug 63804 - commit-log-editor reorders ChangeLog entries in unexpected ways
Summary: commit-log-editor reorders ChangeLog entries in unexpected ways
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://trac.webkit.org/log/trunk
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-01 07:29 PDT by Adam Roben (:aroben)
Modified: 2011-07-01 08:21 PDT (History)
3 users (show)

See Also:


Attachments
commit-log-editor reorders ChangeLog entries in unexpected ways (5.52 KB, patch)
2011-07-01 08:11 PDT, Adam Roben (:aroben)
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-07-01 07:29:25 PDT
In bug 27754, commit-log-editor was changed to reorder ChangeLog entries to try to get the bug title and URL to be at the top of the commit message. This was intended to make commit messages be more git-friendly. (Lots of git tools expect a one-line summary of the change at the top of the commit message.)

This reordering is somewhat surprising, and the conditions under which it is performed are hard to determine. This leads to a surprising experience for users.

I think it would be much better if we just changed the template prepare-ChangeLog uses to put the bug title and URL at the top of the ChangeLog. Then commit-log-editor wouldn't have to do any reordering.
Comment 1 Adam Roben (:aroben) 2011-07-01 08:11:58 PDT
Created attachment 99472 [details]
commit-log-editor reorders ChangeLog entries in unexpected ways
Comment 2 Adam Roben (:aroben) 2011-07-01 08:21:29 PDT
Committed r90229: <http://trac.webkit.org/changeset/90229>