WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
63790
REGRESSION(
r90177
): It caused crashes on Qt in debug mode (Requested by Ossy on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=63790
Summary
REGRESSION(r90177): It caused crashes on Qt in debug mode (Requested by Ossy ...
WebKit Review Bot
Reported
2011-07-01 00:41:46 PDT
http://trac.webkit.org/changeset/90177
broke the build: It caused crashes on Qt in debug mode (Requested by Ossy on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r90177
(22.04 KB, patch)
2011-07-01 00:42 PDT
,
WebKit Review Bot
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
WebKit Review Bot
Comment 1
2011-07-01 00:42:10 PDT
Created
attachment 99437
[details]
ROLLOUT of
r90177
Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment.
WebKit Review Bot
Comment 2
2011-07-01 00:48:07 PDT
Comment on
attachment 99437
[details]
ROLLOUT of
r90177
Clearing flags on attachment: 99437 Committed
r90215
: <
http://trac.webkit.org/changeset/90215
>
WebKit Review Bot
Comment 3
2011-07-01 00:48:12 PDT
All reviewed patches have been landed. Closing bug.
Oliver Hunt
Comment 4
2011-07-01 08:39:35 PDT
Dammit Ossy, stop rolling out entire patches when they causes problems only on qt builds rather than for instance, asking someone who works on qt to fix the problems with it. If you don't understand the code well enough to fix it, you should talk to someone at nokia who does. If you looked at the original bug you would have seen Zoltan saying he would look at it tomorrow (eg. today). Apparently such simple logic is beyond you however.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug