Bug 63790 - REGRESSION(r90177): It caused crashes on Qt in debug mode (Requested by Ossy on #webkit).
Summary: REGRESSION(r90177): It caused crashes on Qt in debug mode (Requested by Ossy ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks: 63757
  Show dependency treegraph
 
Reported: 2011-07-01 00:41 PDT by WebKit Review Bot
Modified: 2011-07-01 08:39 PDT (History)
2 users (show)

See Also:


Attachments
ROLLOUT of r90177 (22.04 KB, patch)
2011-07-01 00:42 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-07-01 00:41:46 PDT
http://trac.webkit.org/changeset/90177 broke the build:
It caused crashes on Qt in debug mode (Requested by Ossy on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2011-07-01 00:42:10 PDT
Created attachment 99437 [details]
ROLLOUT of r90177

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Review Bot 2011-07-01 00:48:07 PDT
Comment on attachment 99437 [details]
ROLLOUT of r90177

Clearing flags on attachment: 99437

Committed r90215: <http://trac.webkit.org/changeset/90215>
Comment 3 WebKit Review Bot 2011-07-01 00:48:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Oliver Hunt 2011-07-01 08:39:35 PDT
Dammit Ossy, stop rolling out entire patches when they causes problems only on qt builds rather than for instance, asking someone who works on qt to fix the problems with it.  If you don't understand the code well enough to fix it, you should talk to someone at nokia who does.  If you looked at the original bug you would have seen Zoltan saying he would look at it tomorrow (eg. today).

Apparently such simple logic is beyond you however.