Bug 63764 - Added empty write barrier stubs in all the right places in the DFG JIT
Summary: Added empty write barrier stubs in all the right places in the DFG JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-30 16:00 PDT by Geoffrey Garen
Modified: 2011-06-30 17:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch (13.54 KB, patch)
2011-06-30 16:04 PDT, Geoffrey Garen 		barraclough: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-06-30 16:00:04 PDT 
Added empty write barrier stubs in all the right places in the DFG JIT
Comment 1 Geoffrey Garen 2011-06-30 16:04:29 PDT 
Created attachment 99386 [details]
Patch
Comment 2 Gavin Barraclough 2011-06-30 16:43:18 PDT 
Comment on attachment 99386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99386&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:-1086
> -        m_jit.loadPtr(globalObject->addressOfRegisters(), temp.gpr());

Maybe addressOfRegisters can go away?
Comment 3 Geoffrey Garen 2011-06-30 17:08:18 PDT 
> Maybe addressOfRegisters can go away?

Alas, alack, it's still used in some places, but I was able to deploy JSVariableObject::offsetOfRegisters() in more places.
Comment 4 Geoffrey Garen 2011-06-30 17:10:28 PDT 
Committed r90187: <http://trac.webkit.org/changeset/90187>