Bug 63763 - new-run-webkit-tests should stop when I ^C it
Summary: new-run-webkit-tests should stop when I ^C it
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-30 15:51 PDT by Adam Barth
Modified: 2011-06-30 16:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.21 KB, patch)
2011-06-30 15:53 PDT, Adam Barth 		dpranke: review+
abarth: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-06-30 15:51:55 PDT 
new-run-webkit-tests should stop when I ^C it
Comment 1 Adam Barth 2011-06-30 15:53:23 PDT 
Created attachment 99383 [details]
Patch
Comment 2 Dirk Pranke 2011-06-30 16:00:25 PDT 
Comment on attachment 99383 [details]
Patch

Ah! I'd been meaning to figure out why that had regressed. Thanks for fixing this.
Comment 3 Dirk Pranke 2011-06-30 16:02:48 PDT 
Oh, as to the "not fast enough" comment ... I agree that it's slow, but much of that slowness is in trying to make sure everything gets cleaned up properly. On some platforms it appears that the child processes don't always get killed themselves by the ctrl-C.

I don't know how much actual room for improvement there may be (in the sense that I literally have no idea, not that I think I had previously done the best possible job).
Comment 4 Adam Barth 2011-06-30 16:05:28 PDT 
Comment on attachment 99383 [details]
Patch

Yeah, I don't have any ideas for making it faster.  Just that it should be faster.  :)
Comment 5 Adam Barth 2011-06-30 16:07:20 PDT 
Committed r90176: <http://trac.webkit.org/changeset/90176>