Bug 63756 - Prevent unnecessary delete of texture 0 in DrawingBuffer
Summary: Prevent unnecessary delete of texture 0 in DrawingBuffer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Canvas (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-30 15:20 PDT by Jeff Timanus
Modified: 2011-07-04 11:16 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.94 KB, patch)
2011-07-04 10:05 PDT, Jeff Timanus
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Timanus 2011-06-30 15:20:44 PDT
The code in DrawingBuffer::clear is structured so that multiple calls to clear will result in deletion of texture 0.  This is general bad GL form, and should be corrected.

Issue also tracked via Chromium bug:  crbug.com/87292
Comment 1 Jeff Timanus 2011-07-04 10:05:56 PDT
Created attachment 99641 [details]
Patch
Comment 2 Stephen White 2011-07-04 10:35:02 PDT
Comment on attachment 99641 [details]
Patch

Looks good.  r=me
Comment 3 WebKit Review Bot 2011-07-04 11:16:46 PDT
Comment on attachment 99641 [details]
Patch

Clearing flags on attachment: 99641

Committed r90369: <http://trac.webkit.org/changeset/90369>
Comment 4 WebKit Review Bot 2011-07-04 11:16:50 PDT
All reviewed patches have been landed.  Closing bug.