Consider the snippet of code: <html> <body> <iframe src="http://example.com"></iframe> </body> </html> If willSendRequest returns 0 for the load of http://example.com, DidFinishLoadForFrame is never called for either the iframe, or the main frame. This is the cause of the unexpected failures mentioned in the Mac WebKit2 Skipped list: # Unexplained failures after implementing willSendRequestReturnsNull fast/loader/onload-willSendRequest-null-for-frame.html plugins/plugin-document-willSendRequest-null.html
Created attachment 99376 [details] [PATCH] Fix
Comment on attachment 99376 [details] [PATCH] Fix Your patch did not apply in the EWS for some reason. But the code change looks great!
(In reply to comment #2) > (From update of attachment 99376 [details]) > Your patch did not apply in the EWS for some reason. But the code change looks great! That is because mac-wk2/Skipped was moved to just platform/wk2/Skipped this morning. I'll need to update and move my Skipped list changes over to that file instead. Thanks for the review!
(In reply to comment #1) > Created an attachment (id=99376) [details] > [PATCH] Fix Would it be possible to write an API test for this?
(In reply to comment #4) > (In reply to comment #1) > > Created an attachment (id=99376) [details] [details] > > [PATCH] Fix > > Would it be possible to write an API test for this? This is covered by layout tests. I could enhance the output of the testing here slightly by having this test dump frame loading callbacks, but it wouldn't change what is being tested.
Landed in r90238.