WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
63729
sheriffbot should use the list of flakey tests from the TestFailures page
https://bugs.webkit.org/show_bug.cgi?id=63729
Summary
sheriffbot should use the list of flakey tests from the TestFailures page
Jessie Berlin
Reported
2011-06-30 09:23:48 PDT
When sheriffbot complains on the IRC channel about a commit breaking the tests on a bot, and it turns out only to be a flakey test, people start ignoring sheriffbot. sheriffbot should use the list of flakey tests, possibly the one that the TestFailures page creates, to make sure it only yells about real breakages as much as is possible.
Attachments
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2011-06-30 10:51:33 PDT
I support this. Python already has logic to avoid flaky tests. It would be nice if the two approaches could be combined. :)
Eric Seidel (no email)
Comment 2
2011-06-30 10:53:59 PDT
Hmm.. at least I think he does.
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/net/failuremap.py
http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/commands/sheriffbot.py#L79
I thought he waited to see something fail twice before reporting.
Eric Seidel (no email)
Comment 3
2011-06-30 10:55:11 PDT
Maybe his flaky test detection got deleted when we stopped having him kick builders? Adam?
Adam Barth
Comment 4
2011-06-30 11:00:55 PDT
Jessie is saying he should use information about
http://build.webkit.org/TestFailures/
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug