We can enable DeviceOrientaion feature for mobile devices.
Created attachment 99410 [details] Proposed Patch Add configure option to enable/disable DeviceOrientation feature. Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.
Comment on attachment 99410 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99410&action=review > Source/WebKit/gtk/WebCoreSupport/DeviceMotionClientGtk.cpp:29 > +namespace WebCore { Why not namespace WebKit? > Source/WebKit/gtk/WebCoreSupport/DeviceOrientationClientGtk.cpp:29 > +namespace WebCore { Why not namespace WebKit?
Created attachment 99436 [details] Proposed Patch2 The QT and Efl port define the WebCore namespace in the source files from the WebCoreSupport directory, but I didn't notice that the GTK+ port defines the WebKit namespace. Anyway, I also think defining the WebKit namespace seems natural because those files are under Source/WebKit directory. Thanks for the review!
Comment on attachment 99436 [details] Proposed Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=99436&action=review > configure.ac:935 > + [enable support for DeviceOrientation (experimental) [default=no]]), Do you mind saying something like "experimental and incomplete" here?
Created attachment 99478 [details] Proposed Patch3 Okay, I've added "incomplete" to the help string.
Comment on attachment 99478 [details] Proposed Patch3 Clearing flags on attachment: 99478 Committed r90240: <http://trac.webkit.org/changeset/90240>
All reviewed patches have been landed. Closing bug.