Bug 63720 - [GTK] Add DeviceOrientation feature
: [GTK] Add DeviceOrientation feature
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Gtk
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks: 52206
  Show dependency treegraph
 
Reported: 2011-06-30 08:18 PDT by Joone Hur
Modified: 2011-07-01 09:56 PDT (History)
4 users (show)

See Also:


Attachments
Proposed Patch (15.12 KB, patch)
2011-06-30 18:15 PDT, Joone Hur
no flags Details | Formatted Diff | Diff
Proposed Patch2 (15.27 KB, patch)
2011-07-01 00:36 PDT, Joone Hur
mrobinson: review+
Details | Formatted Diff | Diff
Proposed Patch3 (15.28 KB, patch)
2011-07-01 09:05 PDT, Joone Hur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joone Hur 2011-06-30 08:18:02 PDT
We can enable DeviceOrientaion feature for mobile devices.
Comment 1 Joone Hur 2011-06-30 18:15:46 PDT
Created attachment 99410 [details]
Proposed Patch

Add configure option to enable/disable DeviceOrientation feature.
Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.
Comment 2 Martin Robinson 2011-06-30 18:20:58 PDT
Comment on attachment 99410 [details]
Proposed Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99410&action=review

> Source/WebKit/gtk/WebCoreSupport/DeviceMotionClientGtk.cpp:29
> +namespace WebCore {

Why not namespace WebKit?

> Source/WebKit/gtk/WebCoreSupport/DeviceOrientationClientGtk.cpp:29
> +namespace WebCore {

Why not namespace WebKit?
Comment 3 Joone Hur 2011-07-01 00:36:13 PDT
Created attachment 99436 [details]
Proposed Patch2

The QT and Efl port define the WebCore namespace in the source files from the WebCoreSupport directory, but I didn't notice that the GTK+ port defines the WebKit namespace. Anyway, I also think defining the WebKit namespace seems natural because those files are under Source/WebKit directory. Thanks for the review!
Comment 4 Martin Robinson 2011-07-01 07:25:09 PDT
Comment on attachment 99436 [details]
Proposed Patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=99436&action=review

> configure.ac:935
> +                             [enable support for DeviceOrientation (experimental) [default=no]]),

Do you mind saying something like "experimental and incomplete" here?
Comment 5 Joone Hur 2011-07-01 09:05:16 PDT
Created attachment 99478 [details]
Proposed Patch3

Okay, I've added "incomplete" to the help string.
Comment 6 WebKit Review Bot 2011-07-01 09:56:33 PDT
Comment on attachment 99478 [details]
Proposed Patch3

Clearing flags on attachment: 99478

Committed r90240: <http://trac.webkit.org/changeset/90240>
Comment 7 WebKit Review Bot 2011-07-01 09:56:38 PDT
All reviewed patches have been landed.  Closing bug.