Bug 63716 - TestFailures page should try to infer which commit caused a failure by looking at commit logs
Summary: TestFailures page should try to infer which commit caused a failure by lookin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/TestFailures/
Keywords:
Depends on:
Blocks: 63745
  Show dependency treegraph
 
Reported: 2011-06-30 07:19 PDT by Adam Roben (:aroben)
Modified: 2011-06-30 13:06 PDT (History)
2 users (show)

See Also:


Attachments
Identify revisions that modified failing tests on TestFailures page (11.32 KB, patch)
2011-06-30 12:35 PDT, Adam Roben (:aroben)
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-06-30 07:19:08 PDT
In cases where a test started failing but the regression range is non-empty (i.e., there are multiple possibly-guilty revisions), it would be nice for TestFailures to look at the commit logs for the possibly-guilty revisions and see if any of them modified the affected test. Then it could call out those revisions as particularly suspicious.
Comment 1 Adam Roben (:aroben) 2011-06-30 09:22:00 PDT
We can get commit logs from Trac, but we'll need to add some CORS headers to trac.webkit.org to allow XHRs from build.webkit.org to succeed.
Comment 2 Adam Roben (:aroben) 2011-06-30 12:35:13 PDT
Created attachment 99355 [details]
Identify revisions that modified failing tests on TestFailures page
Comment 3 Adam Roben (:aroben) 2011-06-30 12:35:38 PDT
Comment on attachment 99355 [details]
Identify revisions that modified failing tests on TestFailures page

Note that this patch won't actually work until we add CORS headers to trac.webkit.org to allow XHRs from build.webkit.org to work.
Comment 4 David Kilzer (:ddkilzer) 2011-06-30 13:01:39 PDT
Comment on attachment 99355 [details]
Identify revisions that modified failing tests on TestFailures page

r=me
Comment 5 Adam Roben (:aroben) 2011-06-30 13:03:53 PDT
Committed r90153: <http://trac.webkit.org/changeset/90153>