[Chromium] Implement some localized string functions
Created attachment 99275 [details] Patch
Comment on attachment 99275 [details] Patch Attachment 99275 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/8960535 New failing tests: fast/html/details-remove-summary-4.html fast/html/details-remove-summary-1.html fast/html/details-no-summary1.html fast/html/details-no-summary3.html fast/html/details-no-summary4.html fast/html/details-remove-summary-1-and-click.html fast/html/details-remove-summary-4-and-click.html fast/html/details-no-summary2.html
Created attachment 99277 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Created attachment 99280 [details] Patch 2
Comment on attachment 99280 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=99280&action=review > Source/WebKit/chromium/public/WebLocalizedString.h:38 > + CrashedPlugin, i'm surprised that our port of webkit would ever require CrashedPlugin or MissingPlugin given how we implement those features in chromium.
Comment on attachment 99280 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=99280&action=review >> Source/WebKit/chromium/public/WebLocalizedString.h:38 >> + CrashedPlugin, > > i'm surprised that our port of webkit would ever require CrashedPlugin or MissingPlugin > given how we implement those features in chromium. Actually, I'm not sure if these strings are used in Chromium except DetailsLabel. I should add only DetailsLabel to avoid unnecessary translations. I'll change the code and land it.
Created attachment 99418 [details] Patch for landing
Comment on attachment 99418 [details] Patch for landing Clearing flags on attachment: 99418 Committed r90195: <http://trac.webkit.org/changeset/90195>
All reviewed patches have been landed. Closing bug.
(In reply to comment #6) > Actually, I'm not sure if these strings are used in Chromium except DetailsLabel. > I should add only DetailsLabel to avoid unnecessary translations. > > I'll change the code and land it. ^^^ thanks.
Committed r91450: <http://trac.webkit.org/changeset/91450>